Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customization for saving pose and image of current simulator view #2198

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

customization for saving pose and image of current simulator view #2198

wants to merge 12 commits into from
+65 −1

Conversation

zovelsanj
Copy link

@zovelsanj zovelsanj commented Sep 7, 2023 •
edited

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zovelsanj
save poses and images for eqrectangle
11464c4
@zovelsanj
added quaternion-to-rotation
e772a25
@zovelsanj
added info on customized method
d840646
@zovelsanj
fixed out_dir code position
f1f7cea
@zovelsanj
fixed frame-skip
b6b0eda
@zovelsanj
customized to save curr view and pose
d82a235 
- customized the code to save the current view of simulator as image and the current state of the agent as transformation matrix.  
- added the above feature when pressing key 'R'.
@facebook-github-bot
Copy link
Contributor

Hi @zovelsanj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 12, 2023
@zovelsanj
resolve merge conflict with main
0a9b386 
- accidentally removed `sim_settings["enable_hbao"] = args.hbao` line. Fixed it now.
@zovelsanj
resolve merge conflict
fab4220 
- newline character showed conflict, so fixed it
@zovelsanj
resolve merge conflicts
8543eee 
removed conflicting newline character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zovelsanj @facebook-github-bot