Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to hide high-vertex-count drawables #2092

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eundersander
Copy link
Contributor

Motivation and Context

Hack to hide high-vertex-count drawables and replace them with wireframe bounding boxes. See ResourceManager.cpp threshold to tune. This is a workaround for displaying Floorplanner scenes in the SIRo sandbox tool on older Macbooks.

We probably won't merge any version of this to main.

How Has This Been Tested

Local testing on 2019 Macbook Pro.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 1, 2023
@eundersander eundersander added do not merge Not ready to merge. This label should block merging. and removed CLA Signed Do not delete this pull request or issue due to inactivity. labels May 1, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 1, 2023
@eundersander eundersander force-pushed the eundersander/hack_hide_high_vert_count_drawables branch 2 times, most recently from a176cdd to 2ab840b Compare June 7, 2023 15:31
@eundersander eundersander force-pushed the eundersander/hack_hide_high_vert_count_drawables branch from 2ab840b to f031c97 Compare June 7, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. do not merge Not ready to merge. This label should block merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants