Restrict navigation to a single floor for 2023 challenge [DO NOT MERGE] #2033
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Skylion007
reviewed
Mar 15, 2023
| @@ -95,6 +95,8 @@ class AgentState: | |||
| class AgentConfiguration: | |||
| height: float = 1.5 | |||
| radius: float = 0.1 | |||
| cell_height: float = 0.2 | |||
There was a problem hiding this comment.
This has bad code smell. There are a lot of navmesh settings and it would be difficult to keep track of them if we add them all here. Perhaps if we add a dictionary of custom NavMesh settings?
There was a problem hiding this comment.
Or why don't we just attach a Navmesh settings object here on the extreme case
There was a problem hiding this comment.
This is fine for a short term thing, but longterm we should consider doing this.
There was a problem hiding this comment.
@Skylion007 - refer to conversation here. TL; DR - these changes are only to support the current iteration of the challenge.
srama2512
changed the title
aclegg3
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change, in conjunction with this commit in habitat-lab, restricts navigation for habitat 2023 challenges to a single floor.
How Has This Been Tested
Tested locally by training ObjectNav agents.
Types of changes
Checklist