Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to put back SPS testing #1996

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Trying to put back SPS testing #1996

wants to merge 3 commits into from
+6 −4

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre self-assigned this Feb 2, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 2, 2023
@aclegg3
Copy link
Contributor

aclegg3 commented Feb 14, 2023

You'll need to run pre-commit on this locally.
Also, a nit: this is not SPS, it is pure FPS (rendering only, no physics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 Awaiting requested review from aclegg3

At least 1 approving review is required to merge this pull request.

Assignees

@vincentpierre vincentpierre

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vincentpierre @aclegg3 @facebook-github-bot