Updated DATASETS.md (semantic annotations in habitat-lab) #1984
+29
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
rpartsey
changed the title
Skylion007
reviewed
Jan 14, 2023
DATASETS.md
Outdated
| habitat: | ||
| simulator: | ||
| agents: | ||
| <agent_name>: |
There was a problem hiding this comment.
NIT: it's not quite clear that this is an variable when listed as key like this. Is there a sensible defualt we can provide them. Or at least add comments to those things which need to be changed.
There was a problem hiding this comment.
Thank you @Skylion007!
How about now?
I agree we should think about how much cross-talk we have b/t lab and sim documentation. If users need to be told how to use datasets in Habitat-lab, maybe it makes more sense to have another DATASETS.md on that side instead of trying to cram it in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I'm not sure if loading semantic annotations in habitat-lab should be part of habitat-sim README.md, but if so, then it has to be updated to Hydra style.
Types of changes