New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sim settings update (taking over for Nakura Mino) #1958
Draft
jrreyna
wants to merge
45
commits into
main
Choose a base branch
from
sim_settings_update_john_reyna_takeover
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+837
−1,240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sim_settings, as well as updating all the ECCV tutorials accordingly
…ction and refactored settings.py file
…pdate_sensor_settings function. Also fixed an error I made setting the default sim settings in the ECCV scripts
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Dec 2, 2022
jrreyna
changed the title
Sim settings update (john reyna takeover)
Sim settings update (taking over for Nakura Mino)
Dec 2, 2022
…e update_sensor_settings function
…_to_settings' and made a new function called 'update_sensor_settings' for clarity. Also made a function in settings.py called 'clear_sensor_settings' so that users don't have to manually clear sensor settings. Lastly, I updated all the scripts and pytests that use the renamed function
…into sim_settings_update_john_reyna_takeover
…lues in settings.py, also added comments to it
…ome reason, it went from passing to failing inexplicably
…into sim_settings_update_john_reyna_takeover
… as a depth sensor was leftover from a previous function
…or_type is depth_sensor, so I simplified that section. Also fixed a bug where I was trying to access agent_id from a sensor spec, even though that isn't a property of sensor specs
…sor_settings to check if a given key in 'kw_args' is valid. Reworked test_sensors.py to use the 'update_or_add_sensor_settings' function, and restructured some of the code accordingly
…and added comments
…laced that function call with its body: sensor_settings = {**default_sensor_settings, **sensor_settings}
…posed to do. Also added lines to remove sensor settings in the test_sensors pytest in certain places that I had removed earlier. Converted those sections of test_sensors on main to the remove/clear functions I wrote in settings.py
…ly'. Also changed code to always add an initial color sensor by default if we are adding a sensor dynamically, as if we are adding a color sensor dynamically, we need to already have one in the scene instantiated when configuring the simulator.
…ors function. Probably not necessary. Also added comments
…est_sensors function. It failed pytest without it
…into sim_settings_update_john_reyna_takeover
…into sim_settings_update_john_reyna_takeover
…ngs} as it is kind of unclear what it does. Instead, I made a function in settings.py that does the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Taking over this PR from NakuraMino. Here was the original description:
The current
habitat_sim.utils.settings.make_cfg()
fn is limited to single first person sensors with the uuidcolor_sensor
,semantic_sensor
etc.e.g.
where
camera_sensor_spec.position = [0, settings["sensor_height"], 0]
.Since many of the examples in
examples/colabs/
use a 1st person sensor AND a 3rd person sensor (e.g. https://github.com/facebookresearch/habitat-sim/blob/main/examples/tutorials/nb_python/ECCV_2020_Interactivity.py#L178), it would be best if you could flexibly add multiple cameras throughsim_settings
.How Has This Been Tested
This passes CI/CD, and these changes are also tested through
pytest tests/*.py
. They all pass.Types of changes
Checklist