Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 integration #5062

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Medoalmasry
Copy link

@Medoalmasry Medoalmasry commented Apr 7, 2023

Before submitting

What does this PR do?

Fixes # (5012).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot
Copy link
Contributor

Hi @Medoalmasry!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sticking to linting rules.
Empty last line
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Robolightning
Copy link

Unfortunately, after these changes, fireseq becomes incompatible with hydra. You do not know how to fix this problem? I also have python 3.11.
On image: caused by an exception in file hydra\core\config_store.py
image

@ponponon
Copy link

ponponon commented Jul 4, 2023

hydra

Which warehouse are you referring to hydra? Is https://pypi.org/project/hydra-core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants