Skip to content

Commit

Permalink
fix missing extra args in ConformerLayer (#5176)
Browse files Browse the repository at this point in the history
* fix missing extra args in ConformerLayer

* fix extra args issue

---------

Co-authored-by: Andros Tjandra <androstj@fb.com>
  • Loading branch information
androstj and androstj committed May 31, 2023
1 parent 533644c commit 456ffcf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions fairseq/models/wav2vec/wav2vec2.py
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ def make_conv_pos(e, k, g):


class TransformerEncoder(nn.Module):
def build_encoder_layer(self, args: Wav2Vec2Config, layer_idx: int):
def build_encoder_layer(self, args: Wav2Vec2Config, **kwargs):
if args.layer_type == "transformer":
layer = TransformerSentenceEncoderLayer(
embedding_dim=self.embedding_dim,
Expand Down Expand Up @@ -972,7 +972,7 @@ def build_encoder_layer(self, args: Wav2Vec2Config, layer_idx: int):
use_adp = True
else:
adp_trf_idx = list(range(*[int(g) for g in args.adp_trf_idx.split(":")]))
if layer_idx in adp_trf_idx:
if kwargs.get("layer_idx", None) in adp_trf_idx:
use_adp = True
if use_adp:
layer = TransformerSentenceEncoderWithAdapterLayer(
Expand Down Expand Up @@ -1050,7 +1050,7 @@ def make_conv_block(e, k, g, l):
)

self.layers = nn.ModuleList(
[self.build_encoder_layer(args, ii) for ii in range(args.encoder_layers)]
[self.build_encoder_layer(args, layer_idx=ii) for ii in range(args.encoder_layers)]
)
self.layer_norm_first = args.layer_norm_first
self.layer_norm = LayerNorm(self.embedding_dim)
Expand Down

0 comments on commit 456ffcf

Please sign in to comment.