Fairscale support for only performing allreduce in last microbatch #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jspark1105
reviewed
Mar 18, 2024
| @@ -70,6 +70,9 @@ def __new__(cls, params: Sequence[nn.Parameter], requires_grad: bool = True) -> | |||
| def __init__(self, params: Sequence[nn.Parameter], requires_grad: bool = True): | |||
| """Initialize the _param_numels and _param_shapes lists.""" | |||
| self._param_numels = [p.numel() for p in params] | |||
| self._param_require_allreduce = [ | |||
There was a problem hiding this comment.
Perhaps more descriptive name is _param_require_tp_allreduce?
There was a problem hiding this comment.
Thanks for the suggestion! I have made the modification.
jiecaoyu
force-pushed
the
ngoyal_changes_for_pp_fp8_jiecaoyu_norm_allreduce
branch
from
9eba19b
to
74a7313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fairscale changes for supporting only performing allreduce in the last microbatch.
The main change in xlformers: https://github.com/fairinternal/xlformers/pull/3236 .
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.