Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the probability of applying GaussianBlur #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Separius
Copy link

Hi,
I've identified a potential issue within the data augmentation pipeline of DINOv2 that appears to deviate from the expected behavior observed in DINO and MoCo-v3. According to the source code for DINO and MoCo-v3, a Gaussian blur is consistently applied to the first global crop. However, in DINOv2, the probability within the GaussianBlur class is erroneously inverted. This is contrary to the documentation and implementation of RandomApply in TorchVision, where p=1 should indeed apply the transformation consistently.

The rectification is straightforward—alter the probability handling to align with the standard expectations. However, this raises two significant questions:

1. Are the pretrained models also affected by this anomaly in data augmentation?
2. If so, what impact might this have on their performance and reliability?

fixing the probability of applying GaussianBlur
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants