Fix build failure with CMake #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the build fails with
```
Undefined symbols for architecture arm64:
"fizz::extensions::generateDelegatedCredentialPEM(fizz::extensions::DelegatedCredential, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)", referenced from:
fizz::tool::fizzGenerateDelegatedCredentialCommand(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) in FizzGenerateDelegatedCredentialCommand.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
This was missed in 19dca4c.
See https://github.com/Homebrew/homebrew-core/actions/runs/8932339958/job/24536092094?pr=170668#step:3:326
|
@mingtaoy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 7, 2024
Summary:
Without this, the build fails with
```
Undefined symbols for architecture arm64:
"fizz::extensions::generateDelegatedCredentialPEM(fizz::extensions::DelegatedCredential, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)", referenced from:
fizz::tool::fizzGenerateDelegatedCredentialCommand(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) in FizzGenerateDelegatedCredentialCommand.cpp.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
This was missed in 19dca4cbe227ad621be1b7bce916840a1b77b12c.
See https://github.com/Homebrew/homebrew-core/actions/runs/8932339958/job/24536092094?pr=170668#step:3:326
X-link: facebookincubator/fizz#116
Reviewed By: frqiu
Differential Revision: D57024059
Pulled By: mingtaoy
fbshipit-source-id: 0788db522ebd4ab516636415012e51316238ed96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the build fails with
This was missed in 19dca4c.
See https://github.com/Homebrew/homebrew-core/actions/runs/8932339958/job/24536092094?pr=170668#step:3:326