Can't build with proxygen's build.sh nor with internal build.sh since today #84
Assignees
Comments
|
Thanks for bringing this to our attention. We'll revert this for now and investigate -- it appears to be a difference between using GNU LD (this is what you are using / is the default) and LLVM LLD (which we use internally). |
facebook-github-bot
pushed a commit
that referenced
this issue
Oct 20, 2022
Summary: Temporarily removes usdt probe that causes error with OSS ld. This works on our lld linker. #84 Reviewed By: mingtaoy Differential Revision: D40523842 fbshipit-source-id: 8b914caa53350e3560c6990dd47d0876319cf274
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this issue
Oct 20, 2022
Summary: Temporarily removes usdt probe that causes error with OSS ld. This works on our lld linker. facebookincubator/fizz#84 Reviewed By: mingtaoy Differential Revision: D40523842 fbshipit-source-id: 8b914caa53350e3560c6990dd47d0876319cf274
facebook-github-bot
pushed a commit
that referenced
this issue
Feb 10, 2023
Summary: Fixes gnu ld linker error where the nop code point injected by a bpf probe was being discarded at linking time. The bpf probe would add reference from the .notes section to this discared func location and a "(...) defined in discarded section (...) referenced in section .note.stapsdt" error would occur. Previously tracked by github issue: (#84) Reviewed By: mingtaoy Differential Revision: D42998995 fbshipit-source-id: a2d1eb0c98823fc90b9886b98e7e5e671362af63
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this issue
Feb 10, 2023
Summary: Fixes gnu ld linker error where the nop code point injected by a bpf probe was being discarded at linking time. The bpf probe would add reference from the .notes section to this discared func location and a "(...) defined in discarded section (...) referenced in section .note.stapsdt" error would occur. Previously tracked by github issue: (facebookincubator/fizz#84) Reviewed By: mingtaoy Differential Revision: D42998995 fbshipit-source-id: a2d1eb0c98823fc90b9886b98e7e5e671362af63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems like after the last changes something was broken.
Here is the commit info
commit a2c1684 (HEAD, origin/main, origin/HEAD, main)
Author: Nick Richardson richardsonnick@meta.com
Date: Tue Oct 18 22:03:23 2022 -0700
error msg:
[100%] Linking CXX executable bin/fizz
.text._ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE' referenced in section.note.stapsdt' of CMakeFiles/FizzTool.dir/tool/FizzClientLoadGenCommand.cpp.o: defined in discarded section.text._ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE[_ZN4fizz6client16AsyncFizzClientTINS0_18ClientStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE]' of CMakeFiles/FizzTool.dir/tool/FizzClientLoadGenCommand.cpp.o.text._ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE' referenced in section.note.stapsdt' of CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.o: defined in discarded section.text._ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE[_ZN4fizz6server16AsyncFizzServerTINS0_18ServerStateMachineEE17ActionMoveVisitorclERNS_15SecretAvailableE]' of CMakeFiles/FizzTool.dir/tool/FizzServerCommand.cpp.ocollect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/FizzTool.dir/build.make:196: bin/fizz] Error 1
make[1]: *** [CMakeFiles/Makefile2:82: CMakeFiles/FizzTool.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
OS: Ubuntu 20.04 used in docker
The text was updated successfully, but these errors were encountered: