Remove error prone secretAvailable USDT

Summary: Temporarily removes usdt probe that causes error with OSS ld. This works on our lld linker. facebookincubator/fizz#84 Reviewed By: mingtaoy Differential Revision: D40523842 fbshipit-source-id: 8b914caa53350e3560c6990dd47d0876319cf274
facebook · Oct 20, 2022 · b32027e · b32027e
1 parent 9744f1c
commit b32027e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/third-party/fizz/src/fizz/client/AsyncFizzClient-inl.h b/third-party/fizz/src/fizz/client/AsyncFizzClient-inl.h
@@ -609,13 +609,15 @@ template <typename SM>
 void AsyncFizzClientT<SM>::ActionMoveVisitor::operator()(
     SecretAvailable& secret) {
   client_.secretAvailable(secret.secret);
+#if 0
   FOLLY_SDT(
       fizz,
       fizz_secret_available,
       secret.secret.secret.size(),
       secret.secret.secret.data(),
       secret.secret.type,
       client_.getClientRandom()->data());
+#endif
 }
 
 template <typename SM>

diff --git a/third-party/fizz/src/fizz/server/AsyncFizzServer-inl.h b/third-party/fizz/src/fizz/server/AsyncFizzServer-inl.h
@@ -343,6 +343,7 @@ void AsyncFizzServerT<SM>::ActionMoveVisitor::operator()(
 template <typename SM>
 void AsyncFizzServerT<SM>::ActionMoveVisitor::operator()(
     SecretAvailable& secret) {
+#if 0
   FOLLY_SDT(
       fizz,
       fizz_secret_available,
@@ -351,6 +352,7 @@ void AsyncFizzServerT<SM>::ActionMoveVisitor::operator()(
       KeyLogWriter::secretToNSSLabel(secret.secret.type)
           .value_or(std::numeric_limits<KeyLogWriter::Label>::max()),
       server_.getClientRandom()->data());
+#endif
   server_.secretAvailable(secret.secret);
 }