This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Add pagination and ratelimit support for responses from Instagram #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 17, 2013 17:23
| def next | ||
| if pagination.next_url | ||
| client = Instagram.client(Instagram.options) | ||
| pagination.next_url.sub!('http://', 'https://') #Make the URL secure if it isn't already |
There was a problem hiding this comment.
Is this really a problem? Aren't all of the API methods limited to https?
There was a problem hiding this comment.
The next URLs that were returned to me in result sets were 'http'.
|
+1 for the ratelimit hash |
|
+1 nice to have |
|
+1 ratelimit |
|
ratelimit info is easily accessible now, see the sample app |
|
Thanks Jonathan, the problem is, that to request the ratelimit it will generate another request. Would be really good to be able to get it from the response as its already available in its header. |
|
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Instagram provides a pagination scheme to allow users to request multiple data sets. This adds support for those requests by adding a "next" method to Instagram::Response. This automatically calls the next URL provided by Instagram and provides a shorter way to request the next page of data from an Instagram response.
In addition, each response now has the ratelimit header information provided by Instagram per https://groups.google.com/forum/#!msg/instagram-api-developers/u5dvkdye-BI/Tb-Dh8zJLDkJ in object.ratelimit.
Due to the architecture of this gem, there is no shared information regarding the Instagram client in either the request or the response, so I had to create a new Instagram::Client object to request the next dataset. Although this works, it doesn't feel ideal.