This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Swap in Facebook Places ID for Foursquare Venue ID in location search #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears Foursquare IDs were deprecated and have been removed from Instagram API docs. It also appears that the Instagram gem wouldn't search with a Facebook Places ID. So, swapped in one for the other.
Aeon
added a commit
to Aeon/instagram-ruby-gem
that referenced
this pull request
Sep 22, 2016
…facebook-places Swap in Facebook Places ID for Foursquare Venue ID in location search
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears Foursquare IDs were deprecated and have recently been removed from Instagram's API docs. It also appears that the Instagram gem wouldn't search with a Facebook Places ID (the request was always going to either have
foursquare_v2_idorlatandlng). So, I swapped in one for the other.This will break any existing use of the
location_searchmethod with a Foursquare Venue ID. Now that Instagram's/locations/searchdocumentation no longer listsfoursquare_v2_idas an option, I expect that this is an acceptable breaking change.Test failures in suite have been fixed in open PR #199.