Added support for UIColor #25

sgl0v · 2014-05-01T23:03:12Z

Implemented feature to edit color value with RGB/HSB color pickers.

…ility of applying custom gradient colors to it.

…nents).

…dded licence.

…I update in RGB color selection controller.

…m RGBA colour space.

…ction views. Fixed callback handling.

…isappears.

…ew class, changed color selection controller accordingly, added missed comments.

…m HSB colour space.

…ews.

…oject warnings, changed demo project to edit background color.

alistra · 2014-07-09T13:21:47Z

Is this planned to be merged in?

grp · 2014-07-09T18:39:11Z

Sorry about leaving this hanging! I wanted to make a few small changes and get it to merge, but it dropped off my radar. I'll get it merged in soon.

bradleydwyer · 2014-07-16T00:15:37Z

Would love to see support for UIColor!

kitschpatrol · 2014-07-19T17:27:09Z

This addition is super helpful! A merge would be great.

landfound · 2015-06-08T02:00:39Z

anyone cares this issue?

ghost · 2015-08-04T18:03:35Z

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

…he keyboard manager's field for controllers, that have content to adjust. Updated the _FBKeyboardManager class accordingly.

…onsistent. Defined the data sources for rgb and hsb views, color wheel and color component cells. Changed the color controller accordingly.

…wheel.

sgl0v · 2015-08-17T20:49:54Z

Hello, guys. Finally I've updated the pull request(merged master branch & fixed all issues I had) and made some changes in the UI (now it is UITableView-based and looks consistent with all other components.). Enjoy!

grp · 2015-08-17T23:18:02Z

I took a quick look at it looks great! A few overall points before I add some notes inline:

Interesting for the choice of representing a color as a hex-string — any reason not to use UIColor directly? Since the 2.0.0 update (adding array support), you should be able to put any NSObject into the tweak value field since they're created lazily through a block at runtime. This would also help avoiding type issues if you legitimately do want a Tweak with a string starting with "#".
A few of the views use auto-layout, but we generally don't use that at Facebook and it occasionally causes compatibility issues. Could you make those use -layoutSubviews instead? (If that would be complicated, it's probably fine as-is, but a little harder to understand.)
Mostly a nit: the rest of the code has the * in pointers next to the variable name, rather than next to the type as you have it for your changes.

grp · 2015-08-17T23:18:48Z

Finally, the HSV support is pretty cool, but it looks like it adds a few more classes just for that. Maybe for simplicity it could just be RGB to start?

grp · 2015-08-17T23:19:02Z

FBTweak/FBColorUtils.h

+ *  @param rgb   The rgb color values
+ *  @param outHSB The hsb color values
+ */
+extern void FBRGB2HSB(RGB rgb, HSB* outHSB);


Any reason to use pointers here versus just a return value?

grp · 2015-08-17T23:24:27Z

Finally, any chance you could post a few screenshots? I'll download it and try it out but best to see it in context.

…youtSubviews methods implementation instead of layout constraints. Refactored according to the code review comments.

…heelCell.

…faultValue property to get the tweak's type.

sgl0v · 2015-08-27T19:58:19Z

Hello Grant,

Looks like I managed to fix all issues you mentioned.

Replaced the hex-string color representation with UIColor;
Removed the auto-layout constraints, added the layoutSubviews method implementations instead;
Minor changes according to the code review.

Yes, probably it would be better to start from the RGB support.

Now it works in this way:

grp · 2015-08-27T23:47:42Z

It's merged! I did a little bit of cleanup on the documentation side, but otherwise looks awesome. Thanks again for making this!

alistra · 2015-08-28T10:55:33Z

I waited for this for so long, is there any cocoapods release planned soon with this?

wjmelements · 2018-07-07T02:56:16Z

FBTweakTests/FBTweakInlineTestsMRR.m

@@ -58,6 +59,9 @@ - (void)testValueTypes
  __attribute__((unused)) NSString *testNSString = FBTweakValue(@"NSString", @"NSString", @"NSString", @"one");
  XCTAssertEqualObjects(testNSString, @"one", @"NSString %@", testNSString);

+  __attribute__((unused)) UIColor *testUIColor = FBTweakValue(@"UIColor", @"UIColor", @"UIColor", [UIColor redColor], [UIColor redColor]);
+  XCTAssertEqualObjects([UIColor redColor], [UIColor redColor], @"UIColor %@", testUIColor);


this doesn't test anything

it should be
XCTAssertEqualObjects(testUIColor, [UIColor redColor], @"UIColor %@", testUIColor);

sgl0v added 23 commits April 7, 2014 23:26

Add UIColor property binding to a tweak.

09e9082

Implemented FBSliderView control. Represents a regular slider with ab…

c6d9f3b

…ility of applying custom gradient colors to it.

Created ColorWheel class for color selection(hue and saturation compo…

059b5a9

…nents).

Updated color wheel bitmap generation, fixed code style formatting, a…

f9488fc

…dded licence.

Implemented view controller to select a color with RGBA components.

8856bcb

Modified: target-action notifying, when the slider's value changed; U…

f179ee7

…I update in RGB color selection controller.

Implemented view, that contains UI elements to select color value fro…

ad5e84a

…m RGBA colour space.

Integrated color selection with the example the project.

f88b6bc

Springs&struts substituted with autolayout constraints for color sele…

7be7941

…ction views. Fixed callback handling.

Fixed auto layout constraints for color components views.

41c3bcd

Changed mechanism of adjusting scrollview when the keyboard appears/d…

f2eda9e

…isappears.

Code refactored, added comments.

45c9997

Code refactored, updated unit tests, created category for UIColor.

c96b4d1

Code refactored.

2718a83

Moved UI construction & setting layout constraints to the separate vi…

b7ff467

…ew class, changed color selection controller accordingly, added missed comments.

Added view controller & views to select color using HSB color space.

29a43d5

Implemented view, that contains UI elements to select color value fro…

3a4fa8e

…m HSB colour space.

Implemented keyboard manager

0266e29

Changed keyboard manager to make it reusable all over the project.

23fc6ec

Refactored rgba color components selection view.

85c4c8c

Implemented color selection controller. Refactored RGB & HSB color vi…

15e2bf4

…ews.

Code refactored, implemented color selection controller , resolved pr…

66a0e80

…oject warnings, changed demo project to edit background color.

Added Facebook licence to the _FBSliderView.m file.

fc6d3c4

sgl0v changed the title ~~Color editor~~ Added support for UIColor May 5, 2014

sgl0v mentioned this pull request May 5, 2014

Support for UIColor and UIFont #5

Open

Changed thumb position calculation in the _FBSliderView class.

df24db0

facebook-github-bot added the CLA Signed label Apr 7, 2015

sgl0v added 5 commits August 16, 2015 13:18

Merge branch 'master' into color

4b87bf8

Removed the global keyboard manager the FBTweakShakeWindow. Defined t…

8b62da2

…he keyboard manager's field for controllers, that have content to adjust. Updated the _FBKeyboardManager class accordingly.

Added the '_' prefix for private classes.

098ff94

Moved to the UITableView usage in order to make application UI more c…

a1af7bd

…onsistent. Defined the data sources for rgb and hsb views, color wheel and color component cells. Changed the color controller accordingly.

Added the pan gesture recognizer to handle tap gestures on the color …

b532683

…wheel.

grp reviewed Aug 17, 2015
View reviewed changes

sgl0v added 4 commits August 25, 2015 22:44

Replaced the hex-string based solution with UIColor one. Added the la…

2fed6de

…youtSubviews methods implementation instead of layout constraints. Refactored according to the code review comments.

Defined function that creates the color wheel.

e9105f4

Removed the _FBColorWheelView. Defined all needed UI in the _FBColorW…

94da040

…heelCell.

Had to specify the property explicitly to bind UIColor. Now we use de…

eab620c

…faultValue property to get the tweak's type.

grp merged commit eab620c into facebookarchive:master Aug 27, 2015

wjmelements reviewed Jul 7, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for UIColor #25

Added support for UIColor #25

sgl0v commented May 1, 2014

alistra commented Jul 9, 2014

grp commented Jul 9, 2014

bradleydwyer commented Jul 16, 2014

kitschpatrol commented Jul 19, 2014

landfound commented Jun 8, 2015

ghost commented Aug 4, 2015

sgl0v commented Aug 17, 2015

grp commented Aug 17, 2015

grp commented Aug 17, 2015

grp Aug 17, 2015

grp commented Aug 17, 2015

sgl0v commented Aug 27, 2015

grp commented Aug 27, 2015

alistra commented Aug 28, 2015

wjmelements Jul 7, 2018

wjmelements Jul 7, 2018

wjmelements Jul 7, 2018

Added support for UIColor #25

Added support for UIColor #25

Conversation

sgl0v commented May 1, 2014

alistra commented Jul 9, 2014

grp commented Jul 9, 2014

bradleydwyer commented Jul 16, 2014

kitschpatrol commented Jul 19, 2014

landfound commented Jun 8, 2015

ghost commented Aug 4, 2015

sgl0v commented Aug 17, 2015

grp commented Aug 17, 2015

grp commented Aug 17, 2015

grp Aug 17, 2015

Choose a reason for hiding this comment

grp commented Aug 17, 2015

sgl0v commented Aug 27, 2015

grp commented Aug 27, 2015

alistra commented Aug 28, 2015

wjmelements Jul 7, 2018

Choose a reason for hiding this comment

wjmelements Jul 7, 2018

Choose a reason for hiding this comment

wjmelements Jul 7, 2018

Choose a reason for hiding this comment