Make linux file write life time hinting work #12595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you have a quick look over this @ajkr ? Cheers! |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cbi42
reviewed
May 6, 2024
env/io_posix.cc
Outdated
| if (hint == write_hint_) { | ||
| return; | ||
| } | ||
| if (fcntl(fd_, F_SET_RW_HINT, &hint) == 0) { | ||
| if (fcntl(fd_, F_SET_RW_HINT, &fcntl_hint)) { |
There was a problem hiding this comment.
good catch! fixed. Thanks!
The life time hint fcntl takes a 64-bit unsigned int, so make sure to pass a uint64_t when doing the syscall. Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
|
@yhr has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The life time hint fcntl takes a 64-bit unsigned int, so make sure to pass a uint64_t when doing the syscall.
See:
https://man7.org/linux/man-pages/man2/fcntl.2.html
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c75b1d9421f80f4143e389d2d50ddfc8a28c8c35
This is one of those "How did this ever work?", as Env::WriteLifeTimeHint hint is definitely not the same as an 64-bit unsigned int.
What's surprising is that SetWriteLifeTimeHint does pass a valid hint from time to time.
Thanks,
Hans