Upgrade jest from 26 to 29 #4686

necolas · 2024-04-24T23:28:06Z

This PR upgrades jest from 26 to 29 and makes related changes. The unit tests pass; the console.error warnings seem to be pre-existing. Included some of them below.

GraphQL fragments wrapped in a thunk

"this is legacy behavior and to be removed in the future"

    console.error
      Warning: RelayGraphQLTag: node `GraphQLTagTest1Query` unexpectedly wrapped in a function.

      67 |   if (typeof node === 'function') {
      68 |     node = (node(): ReaderFragment | ConcreteRequest);
    > 69 |     warning(
         |             ^
      70 |       false,
      71 |       'RelayGraphQLTag: node `%s` unexpectedly wrapped in a function.',
      72 |       node.kind === 'Fragment' ? node.name : node.operation.name,

      at printWarning (node_modules/fbjs/lib/warning.js:30:13)
      at Object.<anonymous>.warning (node_modules/fbjs/lib/warning.js:51:18)
      at getNode (packages/relay-runtime/query/GraphQLTag.js:69:32)
      at Object.getRequest (packages/relay-runtime/query/GraphQLTag.js:156:17)
      at Object.<anonymous> (packages/relay-runtime/query/__tests__/GraphQLTag-test.js:71:37)

Errors in the test-only warnings module.

There were other problematic patterns in this code that I fixed (nesting afterEach within tests; doesn't play well with jest.resetModules).

    console.error
      Unexpected Warning: expected warning #1

      60 |     } else {
      61 |       // log to console in case the error gets swallowed somewhere
    > 62 |       originalConsoleError(`Unexpected ${typenameCap}: ` + message);
         |       ^
      63 |       throw new Error(`${typenameCap}: ` + message);
      64 |     }
      65 |   }

      at handleMessage (packages/relay-test-utils-internal/consoleErrorsAndWarnings.js:62:7)
      at packages/relay-test-utils-internal/warnings.js:29:11
      at packages/relay-test-utils-internal/__tests__/warnings-test.js:84:36
      at Object.expectMessageMany (packages/relay-test-utils-internal/consoleErrorsAndWarnings.js:116:18)
      at Object.expectToWarnMany (packages/relay-test-utils-internal/warnings.js:70:25)
      at packages/relay-test-utils-internal/__tests__/warnings-test.js:83:30
      at Object.<anonymous> (node_modules/expect/build/toThrowMatchers.js:74:11)
      at Object.throwingMatcher [as toThrowError] (node_modules/expect/build/index.js:320:21)
      at Object.<anonymous> (packages/relay-test-utils-internal/__tests__/warnings-test.js:87:8)

Other

   Warning: RelayResponseNormalizer: Payload did not contain a value for field `text: text`. Check that you are parsing with the same query that was used to fetch the payload.

      513 |           // to be present
      514 |           if (__DEV__) {
    > 515 |             warning(
          |                     ^
      516 |               false,
      517 |               'RelayResponseNormalizer: Payload did not contain a value ' +
      518 |                 'for field `%s: %s`. Check that you are parsing with the same ' +

necolas · 2024-04-24T23:28:33Z

package.json

+    "fakeTimers": {
+      "enableGlobally": true,
+      "legacyFakeTimers": true
+    },


Retain legacy timer expectations.

necolas · 2024-04-24T23:28:46Z

package.json

+    "snapshotFormat": {
+      "escapeString": true,
+      "printBasicPrototype": true
+    }


Retain legacy snapshot format.

necolas · 2024-04-24T23:29:38Z

packages/react-relay/relay-hooks/__tests__/useBlockingPaginationFragment-test.js

+const {disallowWarnings, expectWarningWillFire} = (jest.requireActual(
+  'relay-test-utils-internal',
+): $FlowFixMe);


Avoid module getting reset when jest.resetModules is called somewhere in this test, otherwise expectWarningWillFire errors.

necolas · 2024-04-24T23:30:31Z

packages/react-relay/relay-hooks/__tests__/useBlockingPaginationFragment-test.js

@@ -2491,7 +2490,6 @@ describe('useBlockingPaginationFragment', () => {
        // the component twice: `expectFragmentResults` will fail in the next
        // test
        jest.resetModules();
-        disallowWarnings();


Cannot nest this function within a test, because it contains an internal call to afterEach. I'm assuming this was done because of the resetModules, but preventing the module from being reset avoids the issue without triggering the new error about nesting jest hooks

necolas · 2024-04-24T23:30:52Z

packages/react-relay/relay-hooks/__tests__/useLazyLoadQueryNode-test.js

-  disallowWarnings();
-  disallowConsoleErrors();


Cannot nest afterEach within beforeEach

necolas · 2024-04-24T23:31:54Z

packages/relay-runtime/store/__tests__/RelayModernEnvironment-ExecuteMutationWithMatch-test.js

+              setTimeout(() => {
                resolve(markdownRendererNormalizationFragment);
-              });
+              }, 0);


Only use of setImmediate in the tests. No test failures from this change - possibly there are console messages related to it but they were truncated in the test output.

necolas · 2024-04-24T23:32:20Z

scripts/jest/environment.js

@@ -10,6 +10,7 @@

 'use strict';

+global.IS_REACT_ACT_ENVIRONMENT = true;


Needed after upgrading jest

necolas · 2024-04-24T23:32:42Z

scripts/jest/preprocessor.js

@@ -38,7 +38,7 @@ module.exports = {
      filename: filename,
      retainLines: true,
    });
-    return babel.transform(src, options).code;
+    return babel.transform(src, options);


The API changed between 26 and 29

necolas · 2024-04-24T23:33:41Z

packages/relay-test-utils-internal/node.js

+const {
+  FIXTURE_TAG,
+  generateTestsFromFixtures,
+} = require('./generateTestsFromFixtures');


This module uses Node.js APIs. Better to isolate the utils that require a Node environment from those that don't. These helpers are only used in the Babel plugin tests.

necolas · 2024-04-24T23:59:39Z

Are the Rust CI failures unrelated? Locally all the Rust tests pass, but rustup wouldn't let me downgrade to 1.36 on M1 Mac, so it modified Cargo.lock and changed the formatting of every crate file.

facebook-github-bot · 2024-04-25T20:25:14Z

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

necolas · 2024-05-03T16:45:57Z

Closed by 89fe7bc

facebook-github-bot added the CLA Signed label Apr 24, 2024

necolas commented Apr 24, 2024

View reviewed changes

necolas force-pushed the upgrade-jest branch from 14d44b9 to 67dbc89 Compare April 24, 2024 23:57

necolas requested a review from captbaritone April 25, 2024 00:32

Upgrade jest from 26 to 29

ba59107

necolas force-pushed the upgrade-jest branch from 67dbc89 to ba59107 Compare April 25, 2024 20:24

necolas closed this May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade jest from 26 to 29 #4686

Upgrade jest from 26 to 29 #4686

necolas commented Apr 24, 2024 •

edited

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas Apr 24, 2024 •

edited

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas Apr 24, 2024

necolas commented Apr 24, 2024

facebook-github-bot commented Apr 25, 2024

necolas commented May 3, 2024

		@@ -10,6 +10,7 @@

		'use strict';

		global.IS_REACT_ACT_ENVIRONMENT = true;

Upgrade jest from 26 to 29 #4686

Upgrade jest from 26 to 29 #4686

Conversation

necolas commented Apr 24, 2024 • edited

GraphQL fragments wrapped in a thunk

Errors in the test-only warnings module.

Other

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

necolas Apr 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

necolas commented Apr 24, 2024

facebook-github-bot commented Apr 25, 2024

necolas commented May 3, 2024

necolas commented Apr 24, 2024 •

edited

necolas Apr 24, 2024 •

edited