Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema validation report using diagnostics #4685

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make schema validation report using diagnostics #4685

wants to merge 1 commit into from

Conversation

captbaritone
Copy link
Contributor

This PR updates our schema validation crate (which was previously not actually used directly by Relay) to report errors using Diagnostics rather than using its bespoke error reporting approach. This has a few effects:

  1. Error reporting is improved for CLI output for the existing validation tool, with file locations and inline context, and related locations all being reported
  2. As we look to adopt schema validation in Relay proper the errors will be compatible with the LSP meaning they will surface as red underlines in the correct locations.

@facebook-github-bot
Copy link
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@captbaritone @facebook-github-bot