Add code action to create missing operation variable #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
commented
Apr 21, 2024
| @@ -244,53 +282,3 @@ fn create_code_action( | |||
| ..Default::default() | |||
| }) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
There was a problem hiding this comment.
TODO: Re-add this test and tests for the new functionality
| pub struct ValidationDiagnosticCode; | ||
|
|
||
| impl ValidationDiagnosticCode { | ||
| pub const EXPECTED_OPERATION_VARIABLE_TO_BE_DEFINED: i32 = 1; |
There was a problem hiding this comment.
I'm not a fan of this being just an integer. Since the diagnostic code is also shown in the LSP client, ideally it would be something like relay001. But having a string here will likely mean that we can no longer pattern match. Still thinking on a better solution here. Pointers are very welcome :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4679
This extends the
ExpectedOperationVariableToBeDefinederror to include the variable name and type in the diagnostic data. Using this data we create a code action that appends the missing variable with the correct type to the operation variables.