[DRAFT] Devtools remove inspected window.eval #19136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 1, 2020 10:46
1. Remove many of the calls to inspectedWindow.eval() (at least all in critical path) 2. Retry failed injections on interval until acknowledged (seems to fix the issue of reactjs.org sometimes not connecting) 3. Always show Components and Profilers tab even if React isn't on the page (added messaging in that case)
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9892112:
|
tjallingt
reviewed
Jun 15, 2020
|
This does not fix things. Maybe we decide to always show the tab anyway, at some point but I'm going to close this for now as a failed investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #19002 and general initialization/detection logic.
devtools.inspetedWindow.evalusage (all that's in the critical path).This PR also makes a controversial change to always show both "⚛️ Components" and "⚛️ Profiler" tabs. This lets us remove the
setIntervalpolling logic that may have contributed to some cases of us failing to show the tabs, and also sometimes lead to confusion (semi frequent questions of "why don't I see the tabs?"). I can revert this change if it's frowned on though.Here's what the extension looks like if you're on e.g. www.google.com
Light mode
Dark mode