Devtools React Profiler: Shrink flamegraph window's width to make room for scrollbar #17339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gejimayu
changed the title
|
@bvaughn may i ask for review? thanks in advance |
bvaughn
suggested changes
Nov 25, 2019
|
Hi thanks for the response. |
|
Done. |
gejimayu
changed the title
|
I think the current scrollbar UX is fine. It only shows when scrolling is active, then it hides itself again. Permanently shrinking the width would also negatively impact non-Mac/trackpad users since the scrollbar on their systems takes up fixed space already. I appreciate the proposal and sharing the idea 😄 but I don't think we should change anything in this panel. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide scrollbar to appear on flame graph React Profiler.
The reason is that the scrollbar seems to block some of the flame graph. In addition to that, the scrollbar does not serve any purpose.
This is the issue #16550
Before
After / Results
Chrome
Firefox
