New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure that select
has multiple
attribute set to appropriate state before appending options
#13270
Merged
Merged
Make sure that select
has multiple
attribute set to appropriate state before appending options
#13270
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2abb232
Make sure that `select` has `multiple` attribute set to appropriate s…
segoddnja d7c57e5
Add dom test fixture to test long multiple select scrolling to the fi…
segoddnja 5d8d46a
typo fix
segoddnja b17ed8c
update comment
segoddnja b58cc88
Merge remote-tracking branch 'upstream/master'
segoddnja 561efab
change a way of assigning property to domElement
segoddnja afedb68
Remove unused ref on select fixture form
nhunzaker File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -384,6 +384,14 @@ export function createElement( | |
// See discussion in https://github.com/facebook/react/pull/6896 | ||
// and discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1276240 | ||
domElement = ownerDocument.createElement(type); | ||
// Normally attributes are assigned in `setInitialDOMProperties`, however the `multiple` | ||
// attribute on `select`s needs to be added before `option`s are inserted. This prevents | ||
// a bug where the `select` does not scroll to the correct option because singular | ||
// `select` elements automatically pick the first item. | ||
// See https://github.com/facebook/react/issues/13222 | ||
if (type === 'select' && props.multiple) { | ||
domElement.setAttribute('multiple', 'true'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just for consistence with ReactDOMFiberSelect, can you assign this as a property, like: domElement.multiple = true |
||
} | ||
} | ||
} else { | ||
domElement = ownerDocument.createElementNS(namespaceURI, type); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use property assignment in the postMountWrapper, could you do the same here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postMountWrapper
attempts to update options, but as at this moment select doesn't have any child appended, it makes no sense, it will iterate over empty options collection. However it should not cause any problems so if you think it is better approach I can do this change.