Fix/12200 regresssion select multiple

packages/react-art/src/ReactART.js

@@ -431,7 +431,9 @@ const ARTRenderer = ReactFiberReconciler({
   createTextInstance(text, rootContainerInstance, internalInstanceHandle) {
     return text;
   },
-
+  preprocessChildrenSpecialProperties(domElement, type, props) {
+    return false;
+  },
   finalizeInitialChildren(domElement, type, props) {
     return false;
   },

packages/react-dom/src/client/ReactDOM.js

@@ -53,6 +53,7 @@ import {
   DOCUMENT_FRAGMENT_NODE,
 } from '../shared/HTMLNodeType';
 import {ROOT_ATTRIBUTE_NAME} from '../shared/DOMProperty';
+import {setInitialSpecialProperties} from './ReactDOMFiberComponent';
 const {
   createElement,
   createTextNode,
@@ -609,6 +610,15 @@ const DOMRenderer = ReactFiberReconciler({
     return domElement;
   },
 
+  preprocessChildrenSpecialProperties(
+    domElement: Instance,
+    type: string,
+    props: Props,
+    rootContainerInstance: Container,
+  ): void {
+    setInitialSpecialProperties(domElement, type, props, rootContainerInstance);
+  },
+
   appendInitialChild(
     parentInstance: Instance,
     child: Instance | TextInstance,

packages/react-dom/src/client/ReactDOMFiberComponent.js

@@ -413,6 +413,45 @@ export function createTextNode(
     text,
   );
 }
+export function setInitialSpecialProperties(
+  domElement: Element,
+  tag: string,
+  rawProps: Object,
+  rootContainerElement: Element | Document,
+): void {
+  const isCustomComponentTag = isCustomComponent(tag, rawProps);
+  if (__DEV__) {
+    validatePropertiesInDevelopment(tag, rawProps);
+    if (isCustomComponentTag && !didWarnShadyDOM && domElement.shadyRoot) {
+      warning(
+        false,
+        '%s is using shady DOM. Using shady DOM with React can ' +
+          'cause things to break subtly.',
+        getCurrentFiberOwnerName() || 'A component',
+      );
+      didWarnShadyDOM = true;
+    }
+  }
+
+  // TODO: Make sure that we check isMounted before firing any of these events.
+  let props: Object;
+  switch (tag) {
+    case 'select':
+      ReactDOMFiberSelect.initWrapperState(domElement, rawProps);
+      props = ReactDOMFiberSelect.getHostProps(domElement, rawProps);
+      break;
+  }
+
+  assertValidProps(tag, props, getStack);
+
+  setInitialDOMProperties(
+    tag,
+    domElement,
+    rootContainerElement,
+    props,
+    isCustomComponentTag,
+  );
+}
 
 export function setInitialProperties(
   domElement: Element,
@@ -485,8 +524,6 @@ export function setInitialProperties(
       props = ReactDOMFiberOption.getHostProps(domElement, rawProps);
       break;
     case 'select':
-      ReactDOMFiberSelect.initWrapperState(domElement, rawProps);
-      props = ReactDOMFiberSelect.getHostProps(domElement, rawProps);
       trapBubbledEvent('topInvalid', 'invalid', domElement);
       // For controlled components we always need to ensure we're listening
       // to onChange. Even if there is no listener.

packages/react-native-renderer/src/ReactFabricRenderer.js

@@ -186,6 +186,15 @@ const ReactFabricRenderer = ReactFiberReconciler({
     };
   },
 
+  preprocessChildrenSpecialProperties(
+    parentInstance: Instance,
+    type: string,
+    props: Props,
+    rootContainerInstance: Container,
+  ): boolean {
+    return false;
+  },
+
   finalizeInitialChildren(
     parentInstance: Instance,
     type: string,

packages/react-native-renderer/src/ReactNativeFiberRenderer.js

@@ -115,6 +115,15 @@ const NativeRenderer = ReactFiberReconciler({
     return tag;
   },
 
+  preprocessChildrenSpecialProperties(
+    parentInstance: Instance,
+    type: string,
+    props: Props,
+    rootContainerInstance: Container,
+  ): void {
+    // We don't want to do anything here since this will be handled as normal in finalizeInitialChildren.
+  },
+
   finalizeInitialChildren(
     parentInstance: Instance,
     type: string,

packages/react-noop-renderer/src/ReactNoop.js

@@ -109,6 +109,14 @@ let SharedHostConfig = {
     return inst;
   },
 
+  preprocessChildrenSpecialProperties(
+    domElement: Instance,
+    type: string,
+    props: Props,
+  ): boolean {
+    return false;
+  },
+
   appendInitialChild(
     parentInstance: Instance,
     child: Instance | TextInstance,

packages/react-reconciler/src/ReactFiberCompleteWork.js

@@ -53,6 +53,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
   const {
     createInstance,
     createTextInstance,
+    preprocessChildrenSpecialProperties,
     appendInitialChild,
     finalizeInitialChildren,
     prepareUpdate,
@@ -503,6 +504,12 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
               currentHostContext,
               workInProgress,
             );
+            preprocessChildrenSpecialProperties(
+              instance,
+              type,
+              newProps,
+              rootContainerInstance,
+            );
 
             appendAllChildren(instance, workInProgress);
 

packages/react-reconciler/src/ReactFiberReconciler.js

@@ -59,6 +59,12 @@ export type HostConfig<T, P, I, TI, HI, PI, C, CC, CX, PL> = {
     hostContext: CX,
     internalInstanceHandle: OpaqueHandle,
   ): I,
+  setInitialSpecialProperties(
+    parentInstance: I,
+    type: T,
+    props: P,
+    rootContainerInstance: C,
+  ): void,
   appendInitialChild(parentInstance: I, child: I | TI): void,
   finalizeInitialChildren(
     parentInstance: I,

packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.js

@@ -37,12 +37,15 @@ describe('ReactFiberHostContext', () => {
       createInstance: function() {
         creates++;
       },
-      finalizeInitialChildren: function() {
+      preprocessChildrenSpecialProperties: function() {
         return null;
       },
       appendInitialChild: function() {
         return null;
       },
+      finalizeInitialChildren: function() {
+        return null;
+      },
       now: function() {
         return 0;
       },
@@ -86,12 +89,15 @@ describe('ReactFiberHostContext', () => {
       createInstance: function() {
         return null;
       },
-      finalizeInitialChildren: function() {
+      preprocessChildrenSpecialProperties: function() {
         return null;
       },
       appendInitialChild: function() {
         return null;
       },
+      finalizeInitialChildren: function() {
+        return null;
+      },
       now: function() {
         return 0;
       },

packages/react-test-renderer/src/ReactTestRenderer.js

@@ -148,6 +148,15 @@ const TestRenderer = ReactFiberReconciler({
     };
   },
 
+  preprocessChildrenSpecialProperties(
+    testElement: Instance,
+    type: string,
+    props: Props,
+    rootContainerInstance: Container,
+  ): boolean {
+    return false;
+  },
+
   appendInitialChild(
     parentInstance: Instance,
     child: Instance | TextInstance,