Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlinify the remaining interfaces in react.bridge #44546

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented May 12, 2024

Summary:

Changelog:

[Internal] -

This wraps up moving all of the interfaces to Kotling inside react.bridge.

Differential Revision: D57253634

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57253634

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57253634

rshest added a commit to rshest/react-native that referenced this pull request May 12, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: D57253634
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57253634

rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This is the first chunk of moving all of the interfaces to Kotlin inside `react.bridge`, covering the small-ish (functional/SAM and such) interfaces.

Differential Revision: D57253634
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This is the first chunk of moving all of the interfaces to Kotlin inside `react.bridge`, covering the small-ish (functional/SAM and such) interfaces.

Differential Revision: D57253634
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57253634

rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: https://internalfb.com/D57253634
rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: https://internalfb.com/D57253634
rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: https://internalfb.com/D57253634
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,526,139 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,896,044 -9
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d94c4c4
Branch: main

rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: https://internalfb.com/D57253634
rshest added a commit to rshest/react-native that referenced this pull request May 16, 2024
Summary:
Pull Request resolved: facebook#44546

# Changelog:
[Internal] -

This wraps up moving all of the interfaces to Kotling inside `react.bridge`.

Differential Revision: https://internalfb.com/D57253634
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 44bac48.

Copy link

This pull request was successfully merged by @rshest in 44bac48.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants