fix: TextInput npe in #29452 on react native side

[jcdhlzq]

Summary:

Fix the TextInput npe in #29452 on react native side because if it is just avoided on App side by changing themes may cause side effects.

Changelog:

• [ANDROID] [FIXED] - Fix TextInput NPE.

Test Plan:

Thanks to Fabriziobertoglio1987's wok, the problem in #29452 can be tested easily. This fixing works fine and causes no side effects.

The following video shows the test result. And the number 101 has been changed to 1001 in RNTester/TextInputKeyProp.js when testing.

fix-textinput-npe.mp4

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,732,070	-519
android	hermes	armeabi-v7a	8,043,412	-510
android	hermes	x86	9,221,423	-512
android	hermes	x86_64	9,074,399	-513
android	jsc	arm64-v8a	9,297,312	-471
android	jsc	armeabi-v7a	8,486,080	-469
android	jsc	x86	9,358,052	-476
android	jsc	x86_64	9,614,639	-470

Base commit: 2b932c3
Branch: main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[jcdhlzq]

After modifications above, I re-tested TextInputKeyProp.js with 101 changed to 1001 and TextInputExample.js. The npe problem doesn't occur and there no unexpected rendering effects, namely no side effects.

textinput-npe-fixed.mp4

[cipolleschi]

cc. @cortinico @NickGerleman: do you think this is good now? If yes, I can proceed reimporting this and try to land it.

[cortinico]

LGTM 👍

[jcdhlzq]

@cipolleschi Is there anything else to do as the pr is approved and all checks have passed?

[cipolleschi]

@jcdhlzq nope, I'll import it and try to land this.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[jcdhlzq]

we got a warning from "Fackbook Internal - Linter", but i cannot see it in details.

[cipolleschi]

we got a warning from "Fackbook Internal - Linter", but i cannot see it in details.

Yep, that's on us. Internally, we use BUCK to build React Native and TextInputShadowNode uses R from Java, but the dependency from the BUCK rule that knows about R is not stated in the TextInputShadowNode's BUCK files.

@cortinico and I are trying to figure out what is that dependency, fix it and landing. It could take a few days as I'm going to be at a Conference starting from later today.

I'm sorry for the delay.

[jcdhlzq]

we got a warning from "Fackbook Internal - Linter", but i cannot see it in details.

Yep, that's on us. Internally, we use BUCK to build React Native and TextInputShadowNode uses R from Java, but the dependency from the BUCK rule that knows about R is not stated in the TextInputShadowNode's BUCK files.

@cortinico and I are trying to figure out what is that dependency, fix it and landing. It could take a few days as I'm going to be at a Conference starting from later today.

I'm sorry for the delay.

I've re-sync the branch from upstream and now all checks have passed. @cipolleschi

[jcdhlzq]

we got a warning from "Fackbook Internal - Linter", but i cannot see it in details.

Yep, that's on us. Internally, we use BUCK to build React Native and TextInputShadowNode uses R from Java, but the dependency from the BUCK rule that knows about R is not stated in the TextInputShadowNode's BUCK files.
@cortinico and I are trying to figure out what is that dependency, fix it and landing. It could take a few days as I'm going to be at a Conference starting from later today.
I'm sorry for the delay.

I've re-sync the branch from upstream and now all checks have passed. @cipolleschi

It seems that the checks are diffrent from those after you importing the pr.

[cipolleschi]

Yes, the internal linter runs only after importing the PR, so you updated the branch, but we need to reimport it to see if it passes.

[jcdhlzq]

Shall we proceed with this PR this week? @cipolleschi

[cipolleschi]

Hi @jcdhlzq! I'm back from the conference, I'll try to land this as soon as we can.

[facebook-github-bot]

@cipolleschi merged this pull request in 98789e9.

[fabOnReact]

A similar fix was already reviewed by Joshua Gross #27782 (comment) in 2020, so I did not further investigate at that time. Thanks for fixing the issue!

Relavant comment #17530 (comment)