Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds getting started docs with React Native Frameworks #4086

Merged
merged 20 commits into from May 14, 2024

Conversation

jonsamp
Copy link
Contributor

@jonsamp jonsamp commented Apr 21, 2024

This PR changes the docs to share how to get started with a React Native Framework. The changes are screenshotted below.

Screenshots

Get Started with React Native

URL: /docs/next/environment-setup

  • This page now mentions React Native Frameworks.

Get Started with React Native _ React Native

Set Up Your Environment

URL: /docs/next/set-up-your-environment

  • This page talks about how to set your local development environment.

Set Up Your Environment _ React Native · 12 15am · 04-21

Get Started Without a Framework

URL: /docs/next/get-started-without-a-framework

  • This page is referenced on both pages above. It describes how to make a new project with React Native Community CLI and how to run it locally.

Get Started Without a Framework _ React Native

Test plan

Please read through the docs and make sure that they are worded correctly/make sense.

@facebook-github-bot
Copy link

Hi @jonsamp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit bd7577d
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/663ee7485ffeb300080176ca
😎 Deploy Preview https://deploy-preview-4086--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/typescript.md Outdated Show resolved Hide resolved
docs/set-up-your-environment.md Outdated Show resolved Hide resolved
docs/set-up-your-environment.md Outdated Show resolved Hide resolved
docs/set-up-your-environment.md Outdated Show resolved Hide resolved
docs/introduction.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Show resolved Hide resolved
docs/get-started-without-a-framework.md Outdated Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
Comment on lines +14 to +17
You can also use React Native without a Framework, however we’ve found that most developers benefit from using a React Native Framework like [Expo](https://expo.dev). Expo provides features like file-based routing, high-quality universal libraries, and the ability to write plugins that modify native code without having to manage native files.

**If you are already familiar with mobile development**, you may want to use React Native CLI. It requires Xcode or Android Studio to get started. If you already have one of these tools installed, you should be able to get up and running within a few minutes. If they are not installed, you should expect to spend about an hour installing and configuring them.
<details>
<summary>Can I use React Native without a Framework?</summary>
Copy link
Contributor

@brentvatne brentvatne May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use React Native without a Framework ...

shortly after...

<summary>Can I use React Native without a Framework?</summary>

it seems like the paragraph beginning with "You can also.." says a lot of the same things as the details/summary section. (maybe this is fine and the intention, to make it more scannable?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could remove "You can also use React Native without a Framework, however " in the next paragraph, and so it would read like:

We believe that the best way to experience React Native is through a **Framework**, a toolbox with all the necessaries APIs to let you build production ready apps.

We’ve found that most developers benefit from using a React Native Framework like [Expo](https://expo.dev). Expo provides features like file-based routing, high-quality universal libraries, and the ability to write plugins that modify native code without having to manage native files.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting with "Yes" might lend a little clarity, for instance, "Yes, but we believe the best way..."

docs/getting-started.md Outdated Show resolved Hide resolved
@jonsamp jonsamp marked this pull request as ready for review May 8, 2024 20:34
docs/getting-started.md Outdated Show resolved Hide resolved
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 Thanks for the great change @jonsamp

@cortinico cortinico merged commit ccdfe1b into facebook:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants