Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][native-components-android.md] fix render android Fragment with flexbox #4027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kesha-antonov
Copy link
Contributor

@kesha-antonov kesha-antonov commented Feb 23, 2024

Hi

I was creating a library that using Android Fragment and read RN docs about it https://reactnative.dev/docs/native-components-android?android-language=java#integration-with-an-android-fragment-example

But when I opened app I faced issue that flexbox wasn't working and I could set only fixed width & height. And moreover, when I removed width/height with FastRefresh app crashed

Library here: https://github.com/kesha-antonov/react-native-trueconf-sdk

Before changes (based only on RN docs):

1.mp4

After changes (flexbox works & adding/removing width/height doesn't crash the app):

2.mp4

There's also example app: https://github.com/kesha-antonov/react-native-trueconf-sdk/tree/master/example

But you need to comment out these lines to boot it: https://github.com/kesha-antonov/react-native-trueconf-sdk/blob/master/android/build.gradle#L25-L27

And also comment out imports related to com.trueconf since access to those deps available only with credentials

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 10d505a
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/65d904736e64fb000815d49d
😎 Deploy Preview https://deploy-preview-4027--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants