Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to StyleSheetRegistry from StyleSheet docs #3872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alecmarcus
Copy link

Based on some digging, it seems as though StyleSheet no longer uses a registry of IDs:

react-native-community/discussions-and-proposals#400
#629 (comment)

This PR updates the docs to reflect that change.

@facebook-github-bot
Copy link

Hi @alecmarcus!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit d315cd1
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6520bbd4ed9df90008676474
😎 Deploy Preview https://deploy-preview-3872--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@javache
Copy link
Member

javache commented Oct 9, 2023

This is absolutely true, but we do want to keep the option of optimizing this data structure in the future. Users should also not assume a style object is something they can mutate or introspect (without going through flatten), so it'd be great to acknowledge that in the docs.

@rikur
Copy link

rikur commented Apr 12, 2024

Now I'm even more confused. The StyleSheet could really use an update so that users know the best practices.

I've been living in a make-believe world of StyleSheet IDs moving through the bridge for years 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants