Allow optional newline in OpenSSL output #9289
Conversation
Summary: This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3 Pull Request resolved: facebook#9282 Test Plan: The existing tests should still pass with OpenSSL 1.1 ``` "$HHVM_BIN" hphp/test/run.php hphp/test/slow/ext_openssl/ext_openssl.php ``` Differential Revision: D40876120 Pulled By: Atry fbshipit-source-id: 402e333b76853d70931f6898dd15ae9e88d8ecd8
Summary: OpenSSL 3 does not include the trailing newline in its output. This diff adjust `expectf` so that it is now compatible with both OpenSSL 1.1 and 3.0. Differential Revision: D40942191 fbshipit-source-id: 300a35d617566f4335b04c4d7fab03ec774aecf1
|
This pull request was exported from Phabricator. Differential Revision: D40942191 |
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary: OpenSSL 3 does not include the trailing newline in its output. This diff adjust
expectfso that it is now compatible with both OpenSSL 1.1 and 3.0.Differential Revision: D40942191