Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error with OpenSSL 3 #9288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation error with OpenSSL 3 #9288

wants to merge 1 commit into from

Commits on Nov 2, 2022

  1. Fix compilation error with OpenSSL 3 

    Summary:
In OpenSSL 3, `EVP_PKEY_get0_*` functions now return `const` pointers, breaking existing usage depending on mutable pointers returned by OpenSSL 1.x. This diff fix the errors

1. Use `auto` type for return type of `EVP_PKEY_get0_*` functions instead of mutable pointer types.
1. Some `EVP_PKEY_get0_RSA` are replaced with `EVP_PKEY_get1_RSA` in order to get a mutable pointer with the ownership.

See https://www.openssl.org/docs/man3.0/man7/crypto.html#LIBRARY-CONVENTIONS for the `get_0` conventions

Differential Revision: D40942193

fbshipit-source-id: b9a868aec3d332e9de323cb801af52e2692d4686
    @Atry @facebook-github-bot
    Atry authored and facebook-github-bot committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4ee58de View commit details
    Browse the repository at this point in the history