Don't crash when serialize_with_header throws

Summary: This method can throw exceptions, but wasn't marked with except + so it could crash the whole program if serialize_with_header threw. Reviewed By: yoney, ahilger Differential Revision: D57363854 fbshipit-source-id: 7464553a34d6f24cb8c1a3789f0df9995c9d3e0a
facebook · May 16, 2024 · d0d8a63 · d0d8a63
1 parent 9aa41b3
commit d0d8a63
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/third-party/thrift/src/thrift/lib/py3/serializer.pxd b/third-party/thrift/src/thrift/lib/py3/serializer.pxd
@@ -40,5 +40,5 @@ cdef extern from "thrift/lib/cpp/transport/THeader.h" namespace "apache::thrift:
         void setProtocolId(cProtocol)
         uint16_t getProtocolId()
         void setTransform(Transform)
-        unique_ptr[cIOBuf] addHeader(unique_ptr[cIOBuf])
+        unique_ptr[cIOBuf] addHeader(unique_ptr[cIOBuf]) except +
         unique_ptr[cIOBuf] removeHeader(cIOBufQueue*, size_t&, F14NodeMap[string, string]) except +