Make everything_sdt=true the default for hh_single_type_check

Summary: As title says. Remove the `--everything-sdt` flag and make `true` its default setting. To override this, use `--config everything_sdt=false`. At the same time, remove `--enable-sound-dynamic-type` from test config files because it is also now the default. Reviewed By: madgen Differential Revision: D56759937 fbshipit-source-id: ad5113d4ea12d67ec2aba9dd7adaeffb1ed7229c
facebook · May 16, 2024 · 50f7db5 · 50f7db5
1 parent 3e2cf16
commit 50f7db5
Show file tree

Hide file tree

Showing 177 changed files with 904 additions and 728 deletions.
diff --git a/hphp/hack/src/hackrs/compare_folded_decls_file.ml b/hphp/hack/src/hackrs/compare_folded_decls_file.ml
@@ -200,10 +200,6 @@ let () =
       ( "--interpret-soft-types-as-like-types",
         Arg.Set interpret_soft_types_as_like_types,
         "Interpret <<__Soft>> type hints as like types" );
-      ( "--everything-sdt",
-        Arg.Set everything_sdt,
-        " Treat all classes, functions, and traits as though they are annotated with <<__SupportDynamicType>>, unless they are annotated with <<__NoAutoDynamic>>"
-      );
       ( "--enable-strict-const-semantics",
         Arg.Int (fun x -> enable_strict_const_semantics := x),
         " Raise an error when a concrete constants is overridden or multiply defined"

diff --git a/hphp/hack/src/hh_single_decl.ml b/hphp/hack/src/hh_single_decl.ml
@@ -475,10 +475,6 @@ let () =
       ( "--interpret-soft-types-as-like-types",
         Arg.Set interpret_soft_types_as_like_types,
         "Interpret <<__Soft>> type hints as like types" );
-      ( "--everything-sdt",
-        Arg.Set everything_sdt,
-        " Treat all classes, functions, and traits as though they are annotated with <<__SupportDynamicType>>, unless they are annotated with <<__NoAutoDynamic>>"
-      );
       ( "--rust-provider-backend",
         Arg.Set rust_provider_backend,
         " Use the Rust implementation of Provider_backend (including decl-folding)"
@@ -531,7 +527,6 @@ let () =
       ignored_flag "--require-extends-implements-ancestors";
       ignored_flag "--strict-value-equality";
       ignored_flag "--enable-sealed-subclasses";
-      ignored_flag "--enable-sound-dynamic-type";
       ignored_arg "--explicit-consistent-constructors";
       ignored_arg "--require-types-class-consts";
       ignored_flag "--skip-tast-checks";

diff --git a/hphp/hack/src/hh_single_type_check.ml b/hphp/hack/src/hh_single_type_check.ml
@@ -290,7 +290,6 @@ let parse_options () =
   let sharedmem_config = ref SharedMem.default_config in
   let print_position = ref true in
   let enforce_sealed_subclasses = ref false in
-  let everything_sdt = ref false in
   let custom_hhi_path = ref None in
   let force_allow_builtins_in_custom_hhi_path = ref false in
   let explicit_consistent_constructors = ref 0 in
@@ -558,7 +557,6 @@ let parse_options () =
         Arg.Unit
           (fun () ->
             set_bool_ enable_sound_dynamic ();
-            set_bool_ everything_sdt ();
             set_bool_ always_pessimise_return ();
             set_bool_ consider_type_const_enforceable ();
             set_bool_ enable_supportdyn_hint ()),
@@ -567,7 +565,6 @@ let parse_options () =
         Arg.Unit
           (fun () ->
             set_bool_ enable_sound_dynamic ();
-            set_bool_ everything_sdt ();
             set_bool_ enable_supportdyn_hint ()),
         " Enables implicit pessimisation" );
       ( "--explicit-pess",
@@ -721,10 +718,6 @@ let parse_options () =
       ( "--enable-sealed-subclasses",
         Arg.Set enforce_sealed_subclasses,
         " Require all __Sealed arguments to be subclasses" );
-      ( "--everything-sdt",
-        Arg.Set everything_sdt,
-        " Treat all classes, functions, and traits as though they are annotated with <<__SupportDynamicType>>, unless they are annotated with <<__NoAutoDynamic>>"
-      );
       ( "--custom-hhi-path",
         Arg.String (fun s -> custom_hhi_path := Some s),
         " Use custom hhis" );
@@ -849,10 +842,6 @@ let parse_options () =
         config
         |> Config_file.Getters.string_opt "allowed_fixme_codes_strict"
         |> Option.map ~f:comma_string_to_iset;
-      everything_sdt :=
-        config
-        |> Config_file.Getters.bool_opt "everything_sdt"
-        |> Option.value ~default:!everything_sdt;
       enable_sound_dynamic :=
         config
         |> Config_file.Getters.bool_opt "enable_sound_dynamic_type"
@@ -907,7 +896,7 @@ let parse_options () =
         auto_namespace_map = !auto_namespace_map >?? default.auto_namespace_map;
         deregister_php_stdlib =
           !deregister_attributes >?? default.deregister_php_stdlib;
-        everything_sdt = !everything_sdt;
+        everything_sdt = true;
         enable_class_level_where_clauses = !enable_class_level_where_clauses;
         union_intersection_type_hints = !union_intersection_type_hints;
         disallow_silence = !disallow_silence;

diff --git a/hphp/hack/test/count_imprecise_types/dune b/hphp/hack/test/count_imprecise_types/dune
@@ -16,6 +16,7 @@
    .php
    --flags
    --count-imprecise-types
+   --config everything_sdt=false
    --error-format
    plain)))
 

diff --git a/hphp/hack/test/deps/HH_FLAGS b/hphp/hack/test/deps/HH_FLAGS
@@ -1 +1 @@
---dump-deps --no-builtins --enable-sound-dynamic-type --everything-sdt
+--dump-deps --no-builtins
diff --git a/hphp/hack/test/deregister/HH_FLAGS b/hphp/hack/test/deregister/HH_FLAGS
@@ -1 +1 @@
---deregister-attributes --enable-sound-dynamic-type --everything-sdt
+--deregister-attributes
diff --git a/hphp/hack/test/dump_inheritance/HH_FLAGS b/hphp/hack/test/dump_inheritance/HH_FLAGS
@@ -1 +1 @@
---dump-inheritance --enable-sound-dynamic-type --everything-sdt
+--dump-inheritance
diff --git a/hphp/hack/test/dumpsymbolinfo/HH_FLAGS b/hphp/hack/test/dumpsymbolinfo/HH_FLAGS
@@ -1 +1 @@
---dump-symbol-info --enable-sound-dynamic-type --everything-sdt
+--dump-symbol-info
diff --git a/hphp/hack/test/enum_supertyping/typing/HH_FLAGS b/hphp/hack/test/enum_supertyping/typing/HH_FLAGS
@@ -1 +0,0 @@
---enable-sound-dynamic-type --everything-sdt

diff --git a/hphp/hack/test/error_formatting/HH_FLAGS b/hphp/hack/test/error_formatting/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --error-format context
+--error-format context
diff --git a/hphp/hack/test/error_formatting_highlighted/HH_FLAGS b/hphp/hack/test/error_formatting_highlighted/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --error-format highlighted
+--error-format highlighted
diff --git a/hphp/hack/test/error_formatting_highlighted_raw_color/HH_FLAGS b/hphp/hack/test/error_formatting_highlighted_raw_color/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --error-format highlighted
+--error-format highlighted
diff --git a/hphp/hack/test/extended_reasons/HH_FLAGS b/hphp/hack/test/extended_reasons/HH_FLAGS
@@ -1,3 +1,4 @@
 --allowed-fixme-codes-strict 1002,2049,2053,2063,2121,4009,4029,4030,4051,4054,4055,4064,4090,4101,4102,4110,4123,4128,4323,4338,4341,9999,4107
 --allowed-decl-fixme-codes 1002,2049,2053,4030,4054,4101,4338,4341
+--config everything_sdt=false
 --extended-reasons --config --union-intersection-type-hints --extended-reasons
diff --git a/hphp/hack/test/find_local/HH_FLAGS b/hphp/hack/test/find_local/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --find-local
+--find-local
diff --git a/hphp/hack/test/find_refs/HH_FLAGS b/hphp/hack/test/find_refs/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --find-refs 
+--find-refs
diff --git a/hphp/hack/test/go_to_impl/HH_FLAGS b/hphp/hack/test/go_to_impl/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --go-to-impl 
+--go-to-impl
diff --git a/hphp/hack/test/highlight_refs/HH_FLAGS b/hphp/hack/test/highlight_refs/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --highlight-refs
+--highlight-refs
diff --git a/hphp/hack/test/holes/dune b/hphp/hack/test/holes/dune
@@ -23,8 +23,6 @@
    --fallback-expect-extension
    .exp
    --flags
-   --enable-sound-dynamic-type
-   --everything-sdt
    --tast
    --error-format
    plain)))

diff --git a/hphp/hack/test/ide_code_actions/extract_method/HH_FLAGS b/hphp/hack/test/ide_code_actions/extract_method/HH_FLAGS
@@ -0,0 +1 @@
+--config everything_sdt=false
diff --git a/hphp/hack/test/ide_code_actions/extract_shape_type_to_alias/HH_FLAGS b/hphp/hack/test/ide_code_actions/extract_shape_type_to_alias/HH_FLAGS
@@ -0,0 +1 @@
+--config everything_sdt=false
diff --git a/hphp/hack/test/identify_symbol/HH_FLAGS b/hphp/hack/test/identify_symbol/HH_FLAGS
@@ -1 +1 @@
---enable-sound-dynamic-type --everything-sdt --identify-symbol
+--identify-symbol
diff --git a/hphp/hack/test/lint/HH_FLAGS b/hphp/hack/test/lint/HH_FLAGS
@@ -1,3 +1,4 @@
 --lint
 --error-format raw
 --extra-builtin ../hhi/XHPTest.hhi
+--config everything_sdt=false
diff --git a/hphp/hack/test/lint/implicit_pess/HH_FLAGS b/hphp/hack/test/lint/implicit_pess/HH_FLAGS
@@ -1,4 +1,3 @@
 --lint
 --error-format raw
 --extra-builtin ../../hhi/XHPTest.hhi
---implicit-pess
diff --git a/hphp/hack/test/map_reduce/tast_hashes/tast_hashes_test.php.exp b/hphp/hack/test/map_reduce/tast_hashes/tast_hashes_test.php.exp
@@ -2,7 +2,7 @@
   "tast_hashes": {
     "tast_hashes_test.php": {
       "tast_hashes": {
-        "class_tast_hashes": { "\\A": 586315070, "\\B": 793583763 },
+        "class_tast_hashes": { "\\A": 640719681, "\\B": 129984708 },
         "gconst_tast_hashes": { "\\B": 721695479 }
       },
       "error_hashes": []