Remove option math_new_code

Summary: As title says. This is no longer used. Reviewed By: dlreeves Differential Revision: D53420473 fbshipit-source-id: ddf38e331951e5532d750108606d691b619c4295
facebook · Feb 6, 2024 · 12af5a3 · 12af5a3
1 parent c2d0877
commit 12af5a3
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 14 deletions.
diff --git a/hphp/hack/src/hh_single_type_check.ml b/hphp/hack/src/hh_single_type_check.ml
@@ -920,7 +920,6 @@ let parse_options () =
       ~tco_enable_strict_string_concat_interp:
         !enable_strict_string_concat_interp
       ~tco_ignore_unsafe_cast:!ignore_unsafe_cast
-      ~tco_math_new_code:true
       ~tco_typeconst_concrete_concrete_error:!typeconst_concrete_concrete_error
       ~tco_enable_strict_const_semantics:!enable_strict_const_semantics
       ~tco_strict_wellformedness:!strict_wellformedness

diff --git a/hphp/hack/src/options/globalOptions.ml b/hphp/hack/src/options/globalOptions.ml
@@ -164,7 +164,6 @@ type t = {
   tco_enable_expression_trees: bool;
   tco_enable_function_references: bool;
   tco_allowed_expression_tree_visitors: string list;
-  tco_math_new_code: bool;
   tco_typeconst_concrete_concrete_error: bool;
   tco_enable_strict_const_semantics: int;
   tco_strict_wellformedness: int;
@@ -296,7 +295,6 @@ let default =
     tco_enable_expression_trees = false;
     tco_enable_function_references = false;
     tco_allowed_expression_tree_visitors = [];
-    tco_math_new_code = false;
     tco_typeconst_concrete_concrete_error = false;
     tco_enable_strict_const_semantics = 0;
     tco_strict_wellformedness = 0;
@@ -426,7 +424,6 @@ let set
     ?tco_enable_expression_trees
     ?tco_enable_function_references
     ?tco_allowed_expression_tree_visitors
-    ?tco_math_new_code
     ?tco_typeconst_concrete_concrete_error
     ?tco_enable_strict_const_semantics
     ?tco_strict_wellformedness
@@ -705,7 +702,6 @@ let set
       setting
         tco_allowed_expression_tree_visitors
         options.tco_allowed_expression_tree_visitors;
-    tco_math_new_code = setting tco_math_new_code options.tco_math_new_code;
     tco_typeconst_concrete_concrete_error =
       setting
         tco_typeconst_concrete_concrete_error

diff --git a/hphp/hack/src/options/globalOptions.mli b/hphp/hack/src/options/globalOptions.mli
@@ -232,9 +232,6 @@ type t = {
       (** Enable unstable feature: function references *)
   tco_allowed_expression_tree_visitors: string list;
       (** Allowed expression tree visitors when not enabled via unstable features flag *)
-  tco_math_new_code: bool;
-      (** Use a new error code for math operations: addition, subtraction,
-        division, multiplication, exponentiation *)
   tco_typeconst_concrete_concrete_error: bool;
       (** Raise an error when a concrete type constant is overridden by a concrete type constant
          in a child class. *)
@@ -402,7 +399,6 @@ val set :
   ?tco_enable_expression_trees:bool ->
   ?tco_enable_function_references:bool ->
   ?tco_allowed_expression_tree_visitors:string list ->
-  ?tco_math_new_code:bool ->
   ?tco_typeconst_concrete_concrete_error:bool ->
   ?tco_enable_strict_const_semantics:int ->
   ?tco_strict_wellformedness:int ->

diff --git a/hphp/hack/src/oxidized/gen/global_options.rs b/hphp/hack/src/oxidized/gen/global_options.rs
@@ -3,7 +3,7 @@
 // This source code is licensed under the MIT license found in the
 // LICENSE file in the "hack" directory of this source tree.
 //
-// @generated SignedSource<<e369cf9405c94b9fde084546fd7f32e6>>
+// @generated SignedSource<<54e4a53637f155ff68fe05487f5dc019>>
 //
 // To regenerate this file, run:
 //   hphp/hack/src/oxidized_regen.sh
@@ -175,7 +175,6 @@ pub struct GlobalOptions {
     pub tco_enable_expression_trees: bool,
     pub tco_enable_function_references: bool,
     pub tco_allowed_expression_tree_visitors: Vec<String>,
-    pub tco_math_new_code: bool,
     pub tco_typeconst_concrete_concrete_error: bool,
     pub tco_enable_strict_const_semantics: isize,
     pub tco_strict_wellformedness: isize,

diff --git a/hphp/hack/src/oxidized/manual/global_options_impl.rs b/hphp/hack/src/oxidized/manual/global_options_impl.rs
@@ -129,7 +129,6 @@ impl Default for GlobalOptions {
             tco_enable_function_references: false,
             tco_enable_expression_trees: false,
             tco_allowed_expression_tree_visitors: vec![],
-            tco_math_new_code: false,
             tco_typeconst_concrete_concrete_error: false,
             tco_enable_strict_const_semantics: 0,
             tco_strict_wellformedness: 0,

diff --git a/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs b/hphp/hack/src/oxidized_by_ref/manual/global_options_impl.rs
@@ -115,7 +115,6 @@ const DEFAULT: GlobalOptions<'_> = GlobalOptions {
     tco_enable_modules: false,
     tco_enable_function_references: false,
     tco_allowed_expression_tree_visitors: &[],
-    tco_math_new_code: false,
     tco_typeconst_concrete_concrete_error: false,
     tco_enable_strict_const_semantics: 0,
     tco_strict_wellformedness: 0,

diff --git a/hphp/hack/src/server/serverConfig.ml b/hphp/hack/src/server/serverConfig.ml
@@ -353,7 +353,6 @@ let load_config config options =
       (Option.map
          (string_list_opt "allowed_expression_tree_visitors" config)
          ~f:(fun l -> List.map l ~f:Utils.add_ns))
-    ?tco_math_new_code:(bool_opt "math_new_code" config)
     ?tco_typeconst_concrete_concrete_error:
       (bool_opt "typeconst_concrete_concrete_error" config)
     ?tco_enable_strict_const_semantics: