Implement TypedArray.prototype.toReversed
#1366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 29, 2024
|
@dannysu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
dannysu
requested changes
Apr 16, 2024
| double from = len - k - 1; | ||
|
|
||
| // 6b. Let Pk be ! ToString(𝔽(k)). | ||
| kHandle = HermesValue::encodeTrustedNumberValue(k); |
There was a problem hiding this comment.
kHandle is unused other than being assigned here. Could you please remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements ES2023
TypedArray.prototype.toReversedmethod. This is a follow-up of PR #1286 which added with method on standard Array prototype.See also:
TypedArray.prototype.with: ImplementTypedArray.prototype.with#1365TypedArray.prototype.toSorted: ImplementTypedArray.prototype.toSorted#1367I am creating separate PRs for each method in case there are any suggestions or change requests from your side, so that PRs are more independent.
Test Plan
Code is annotated with algorithm steps from EcmaScript specification for easier verification and maintenance.
I also added tests to verify that methods work as intended. There might be some more edge cases that might be covered based on your experience.