Allow serializing undefined in object literals #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D53838779
Differential Revision: D29760022
Differential Revision: D29760023
Differential Revision: D29760024
Differential Revision: D29775882
Summary: Optional fields and fields that refer to other classes are initialised to `undefined`, which means that we often end up with `undefined` in literals now. To address this, add the ability to serialize undefined, at the expense of eliminating the `ByteString` tag. Differential Revision: D45014095
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45014095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Optional fields and fields that refer to other classes are initialised
to
undefined, which means that we often end up withundefinedinliterals now.
To address this, add the ability to serialize undefined, at the expense
of eliminating the
ByteStringtag.Differential Revision: D45014095