Fix error: signed shift result
#1259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
```
hermes/Support/StringTableEntry.h:19:44: error: signed shift result (0x80000000) sets the sign bit of the shift expression's type ('int') and becomes negative [-Werror,-Wshift-sign-overflow]
```
which allows the `-Wshift-sign-overflow` flag to be set.
facebook-github-bot
added
the
CLA Signed
tmikov
reviewed
Jan 17, 2024
| @@ -16,7 +16,7 @@ namespace hermes { | |||
|
|
|||
| /// An entry in the string table inside the ConsecutiveStringStorage. | |||
| class StringTableEntry { | |||
| static constexpr uint32_t UTF16_MASK = 1 << 31; | |||
| static constexpr uint32_t UTF16_MASK = static_cast<uint32_t>(1) << 31; | |||
There was a problem hiding this comment.
We prefer C-style casts for trivial cases like this. (uint32_t)1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
which allows the
-Wshift-sign-overflowflag to be set.Test Plan
Standard CI