Revive D51728257 with fix #1224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52213926 |
lavenzg
force-pushed
the
export-D52213926
branch
from
e8369c0
to
9506845
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 15, 2023
Summary: Revive the localtime() thread safety change which is reverted due to crashes on Windows (D52210979). Fix is applied. Differential Revision: D52213926
|
This pull request was exported from Phabricator. Differential Revision: D52213926 |
lavenzg
force-pushed
the
export-D52213926
branch
from
9506845
to
bea5663
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 15, 2023
Summary: Revive the localtime() thread safety change which is reverted due to crashes on Windows (D52210979). Fix is applied. Differential Revision: D52213926
|
This pull request was exported from Phabricator. Differential Revision: D52213926 |
Summary: Revive the localtime() thread safety change which is reverted due to crashes on Windows (D52210979). Fix is applied. Differential Revision: D52213926
lavenzg
force-pushed
the
export-D52213926
branch
from
bea5663
to
84625f8
Compare
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Dec 15, 2023
Summary: Revive the localtime() thread safety change which is reverted due to crashes on Windows (D52210979). Fix is applied. Differential Revision: D52213926
|
This pull request was exported from Phabricator. Differential Revision: D52213926 |
lavenzg
force-pushed
the
export-D52213926
branch
from
84625f8
to
e2308e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52213926 |
Brugarolas
added a commit
to Brugarolas/hermes
that referenced
this pull request
Dec 23, 2023
Revive D51728257 with fix (facebook#1224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revive the localtime() thread safety change which is reverted due to
crashes on Windows (D52210979). Fix is applied.
Differential Revision: D52213926