Improve test262 test suites on Apple and Android #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ewlsh
force-pushed
the
evanmh-update-testsuites
branch
from
a9fca42
to
cb9701b
Compare
Many tests which use "const" are not actually testing the behavior of the "const" keyword, they are just using it as it is standard practice in newer JavaScript versions. This allows allowlisting individual tests or directories which use "const". This commit additionally updates the skiplist for ECMA-402 2024
Also update the Android test262 runner to print the individual testcases for debugging and visibility.
ewlsh
force-pushed
the
evanmh-update-testsuites
branch
from
cb9701b
to
ff9e982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For Android, this parameterizes the testsuite so each individual testcase/file is displayed separately and can be opened for debugging.
Additionally this ports the "exclude features" feature from the Apple testsuite to the Android one. This avoids having to exclude numerous test files for the same reason.
For iOS, this adds an "allowlist" to ensure we aren't excluding modern tests which use "const" but don't rely on its actual behavior.
Test Plan
The existing testsuite should pass.