Draft: Add support for dayPeriod and fractionalSecondDigits in Intl.DateTimeFormat #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests which use "const" are not actually testing the behavior of the "const" keyword, they are just using it as it is standard practice in newer JavaScript versions. This allows allowlisting individual tests or directories which use "const". This commit additionally updates the skiplist for ECMA-402 2024
Also update the Android test262 runner to print the individual testcases for debugging and visibility.
In DateTimeFormat the switch statement for the fractionalSecondDigits skeleton currently is missing "break" statements - leading to incorrect skeleton strings (e.g. SSSSSSS)
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
dayPeriodandfractionalSecondDigitswithinIntl.DateTimeFormaton Apple and Android platforms.On Apple we already had partial support for fractionalSecondDigits, but it was implemented with a bug - missing
break;statements in aswitchmeant that the skeleton was incorrectly composed.On Android we lacked support for
dayPeriodandfractionalSecondDigits, on Android we can only support "flexible day period" (ICU/Unicode naming) on Android Pie (28), so for older versions we fallback to "am"/"pm"Test Plan
The Intl test suite has been updated to run
dayPeriodandfractionalSecondDigitsconformance tests