refactor(promise): don't include the promise rejection tracker hook in the bytecode

[ecreeth]

Summary

We're including the rejection tracking hook in the Promise's bytecode.
According to the library authors, due to the performance cost, we should only do this during development

The React Native repo already is enabling the enablePromiseRejectionTracker during development.

// register the JavaScript implemented `enable` function into
// the Hermes' internal promise rejection tracker.
var enableHook = require('promise/setimmediate/rejection-tracking').enable
HermesInternal?.setPromiseRejectionTrackingHook?.(enableHook);

I just remove the hook registration and run the gen-promise-internal-bc.sh

[ecreeth]

I'm getting an Uncaught TypeError: Promise rejection tracking hook was not registered from hermesInternalEnablePromiseRejectionTracker. I need to investigate a little, so I'm going to convert the PR to draft.

[avp]

This part of the code has a couple moving parts, so maybe I can help explain what's going on here:

The code in promise/index.js in Hermes are calling setPromiseRejectionTrackingHook, which performs a different operation from enablePromiseRejectionTracker.

• setPromiseRejectionTrackingHook is entirely internal to Hermes - it's only got the one callsite in InternalBytecode. It doesn't actually enable promise rejection tracking; it only sets up a single pointer inside the Runtime to point to the enable closure (https://github.com/facebook/hermes/blob/main/lib/VM/JSLib/HermesInternal.cpp#L712)

• enablePromiseRejectionTracker is called (in development mode) by RN or any other integrator with any options they choose.

The reason you're getting a TypeError is that Hermes expects the hook to be set, because it has no way of knowing whether a caller wants to enable it.

The doc-comments on those two functions here might also help: https://github.com/facebook/hermes/blob/main/lib/VM/JSLib/HermesInternal.cpp#L697