Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTE lint-ignore message cleanup at fbcode #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

HTE lint-ignore message cleanup at fbcode #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions fboss/agent/hw/bcm/BcmEcmpUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ getEcmpGroupInHw(const BcmSwitch* hw, bcm_if_t ecmp, int sizeInSw) {
existing.ecmp_intf = ecmp;
int pathsInHwCount;
if (hw->getPlatform()->getAsic()->isSupported(HwAsic::Feature::HSDK)) {
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
bcm_l3_ecmp_member_t pathsInHw[sizeInSw];
bcm_l3_ecmp_get(
hw->getUnit(), &existing, sizeInSw, pathsInHw, &pathsInHwCount);
Expand All @@ -39,7 +39,7 @@ getEcmpGroupInHw(const BcmSwitch* hw, bcm_if_t ecmp, int sizeInSw) {
}
}
} else {
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
bcm_if_t pathsInHw[sizeInSw];
bcm_l3_egress_ecmp_get(
hw->getUnit(), &existing, sizeInSw, pathsInHw, &pathsInHwCount);
Expand Down
14 changes: 7 additions & 7 deletions fboss/agent/hw/bcm/BcmEgress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ void BcmEcmpEgress::program() {
if (ucmpSupported_) {
obj.ecmp_group_flags = BCM_L3_ECMP_MEMBER_WEIGHTED;
}
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
bcm_l3_ecmp_member_t ecmpMemberArray[numPaths];
auto idx = 0;
for (const auto& path : egressId2Weight_) {
Expand Down Expand Up @@ -364,7 +364,7 @@ void BcmEcmpEgress::program() {
createWideEcmpEntry(numPaths);
return;
} else {
// @lint-ignore HOWTOEVEN CLANGTIDY
// @lint-ignore CLANGTIDY
bcm_if_t pathsArray[numPaths];
auto index = 0;
for (const auto& path : egressId2Weight_) {
Expand Down Expand Up @@ -576,7 +576,7 @@ bool BcmEcmpEgress::removeEgressIdHwNotLocked(
ret = bcm_l3_ecmp_get(unit, &existing, 0, nullptr, &totalMembersInHw);
bcmCheckError(ret, "Unable to get ecmp entry ", ecmpId);
if (totalMembersInHw > 0) {
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
bcm_l3_ecmp_member_t membersInHw[totalMembersInHw];
ret = bcm_l3_ecmp_get(
unit, &existing, totalMembersInHw, membersInHw, &totalMembersInHw);
Expand Down Expand Up @@ -705,7 +705,7 @@ bool BcmEcmpEgress::addEgressIdHwLocked(
existing.ecmp_intf = ecmpId;
int countInHw = 0;
int ret;
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
bcm_l3_ecmp_member_t membersInHw[numPaths];
int totalMembersInHw = -1;
int memberIndex = -1;
Expand All @@ -727,7 +727,7 @@ bool BcmEcmpEgress::addEgressIdHwLocked(
}
}
} else {
// @lint-ignore HOWTOEVEN CLANGTIDY CArray
// @lint-ignore CLANGTIDY
// In WideECMP case, HW will have kMaxWeightedEcmpPaths entries
bcm_if_t pathsInHw[kMaxWeightedEcmpPaths];
int totalPathsInHw;
Expand Down Expand Up @@ -930,7 +930,7 @@ void BcmEcmpEgress::programWideEcmp(
bcm_l3_egress_ecmp_t obj;
bcm_l3_egress_ecmp_t_init(&obj);
// weighted path size needs to be power of 2
// @lint-ignore HOWTOEVEN CLANGTIDY
// @lint-ignore CLANGTIDY
bcm_if_t pathsArray[kMaxWeightedEcmpPaths];
auto index = 0;
if (id != INVALID) {
Expand Down Expand Up @@ -974,7 +974,7 @@ bool BcmEcmpEgress::rebalanceWideEcmpEntry(
int unit,
EgressId ecmpId,
std::pair<EgressId, int> toRemove) {
// @lint-ignore HOWTOEVEN CLANGTIDY
// @lint-ignore CLANGTIDY
bcm_if_t pathsInHw[kMaxWeightedEcmpPaths];
int totalPathsInHw;
bcm_l3_egress_ecmp_t obj;
Expand Down