-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed typos #87
Open
midopooler
wants to merge
1
commit into
facebook:main
Choose a base branch
from
midopooler:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixed typos #87
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,37 +9,37 @@ switches. | |
FBOSS consists of a number of user-space applications, libraries, and | ||
utilities. | ||
|
||
The initial open source release of FBOSS consists primarily of the agent | ||
The initial open-source release of FBOSS consists primarily of the agent | ||
daemon, but we are working on releasing additional pieces and functionality as | ||
well. | ||
|
||
### Agent Daemon | ||
|
||
One of the central pieces of FBOSS is the agent daemon, which runs on each | ||
switch, and controls the hardware forwarding ASIC. The agent daemon sends | ||
forwarding information to the hardware, and implements some control plane | ||
protocols such as ARP and NDP. The agent provides thrift APIs for managing | ||
switch, and controls the hardware forwarding ASIC. The agent daemon sends | ||
forwarding information to the hardware and implements some control plane | ||
protocols such as ARP and NDP. The agent provides thrift APIs for managing | ||
routes, to allow external routing control processes to get their routing | ||
information programmed into the hardware forwarding tables. | ||
|
||
The code for the agent can be found in fboss/agent | ||
|
||
The agent requires a JSON configuration file to specify its port and VLAN | ||
configuration. Some sample configuration files can be found under | ||
fboss/agent/configs. These files are not really intended for human | ||
consumption--at Facebook we have tooling that generates these files for us. | ||
The agent requires a JSON configuration file to specify it's port and VLAN | ||
configuration. Some sample configuration files can be found under | ||
fboss/agent/configs. These files are not really intended for human | ||
consumption--at Facebook, we have tooling that generates these files for us. | ||
|
||
### Routing Daemon | ||
|
||
The FBOSS agent manages the forwarding tables in the hardware ASIC, but it | ||
needs to be informed of the current routes via thrift APIs. | ||
|
||
Our initial open source release does not yet contain a routing protocol daemon | ||
capable of talking to the agent. The routing protocol daemon we use at | ||
Our initial open-source release does not yet contain a routing protocol daemon | ||
capable of talking to the agent. The routing protocol daemon we use at | ||
Facebook is rather specific to our environment, and likely won't be as useful | ||
to the open source community. For more general use outside of Facebook, it | ||
to the open-source community. For more general use outside of Facebook, it | ||
should be possible to modify existing open source routing tools to talk to the | ||
FBOSS agent, but we have not implemented this yet. In the meantime, we have | ||
FBOSS agent, but we have not implemented this yet. In the meantime, we have | ||
included a small sample python script in fboss/agent/tools that can manually | ||
add and remove routes. | ||
|
||
|
@@ -49,8 +49,8 @@ Obviously additional tools and utilities are required for interacting with the | |
FBOSS agent, reporting its status, generating configuration files, and | ||
debugging issues. | ||
|
||
At the moment we do not have many of our tools ready for open source release, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also not required @midopooler |
||
but we hope to make more of these available in the future weeks. In the | ||
At the moment we do not have many of our tools ready for open-source release, | ||
but we hope to make more of these available in the future weeks. In the | ||
meantime, the thrift compiler can automatically generate a python-remote script | ||
to allow manual invocation of the agent's various thrift interfaces. | ||
|
||
|
@@ -61,12 +61,12 @@ See the BUILD.md document for instructions on how to build FBOSS. | |
## Future Development | ||
|
||
FBOSS has been designed specifically to handle the needs of Facebook's data | ||
center networks, but we hope it can be useful for the wider community as well. | ||
centre networks, but we hope it can be useful for the wider community as well. | ||
However, note that this initial release of FBOSS will likely require | ||
modification and additional development to support other network configurations | ||
beyond the features used by Facebook. Until it matures more, FBOSS will likely | ||
beyond the features used by Facebook. Until it matures more, FBOSS will likely | ||
be primarily of interest to network software developers, rather than to network | ||
administrators who are hoping to use it as an turnkey solution. | ||
administrators who are hoping to use it as a turnkey solution. | ||
|
||
We look forward to getting feedback from the community, and we hope FBOSS can | ||
serve as a jumping-off point for other users wishing to program network | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt required @midopooler