Fix FBOSS Python Tools building procedure #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggiamarchi
commented
Jul 30, 2018
ggiamarchi
commented
- Install python-pip in order to install missing pip packages
- Use Facebook thrift binary instead of the standard version
- Add missing thrift generation for qsfp_service
- Error "can't find generator 'cpp2' error" is no longer present
- Fix import in send_pkt
capveg
suggested changes
Aug 29, 2018
There was a problem hiding this comment.
Thanks for the update to this documentation! I wrote this before I even joined facebook so it's at least 3 years old and definitely out of date.
FYI: the fboss_route.py command is effectively deprecated in favor of the fboss cli which is in fboss/py - but I think most of the work you've documented here still applies because it applies to the thrift dependencies.
If you can fix up the spelling mistake, I'd be happy to accept!
Thanks again
fboss/agent/tools/README.md
Outdated
|
|
||
| apt-get install python-ipaddr python-thrift thrift-compiler | ||
| export FBOSS=/path/to/base/of/code | ||
| FBOSS ans its extarnal dependencies are supposed to be compiled in order to build FBOSS Python Tools. See [facebook/fboss/build.md](https://github.com/facebook/fboss/blob/master/BUILD.md) |
* Install python-pip in order to install missing pip packages * Use Facebook thrift binary instead of the standard version * Add missing thrift generation for qsfp_service * Error "can't find generator 'cpp2' error" is no longer present * Fix import in send_pkt
ggiamarchi
force-pushed
the
fix-fboss-py-tools
branch
from
e2ddfd7
to
9cd232f
Compare
|
@capveg Spelling mistake fixed |
arajeev-ARISTA
pushed a commit
to arajeev-ARISTA/fboss
that referenced
this pull request
Sep 26, 2023
…_5_2023 Pull Upstream FBOSS OSS 9/52023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.