Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UnityEngine.JsonUtility.ToJson(value) instead of SerializeString(value.ToString()) to serialize 'other' values. #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sotirosn
Copy link

Improved MiniJson.Json.Serialize to utilize UnityEngine.JsonUtility.ToJson() to serialize System.Serializable classes/structs, rather than serializing the string of the object's ToString(). This allows for much more robust serialization. For example you can do this:

[System.Serializable]
public struct MyData {
   public string id;
   public long timestamp;
   public string message;
}

MyData[] data = GetSomeData();
Json.Serialize(data);  

outputs: [{"id":"...","timestamp":1234,"message":"..."},{"id":"...","timestamp":1234,"message":"..."}]
instead of: ["MyData","MyData"]

…oJson to serialize System.Serializable classes/structs, rather than serializing the string of the object's ToString.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@sotirosn
Copy link
Author

I suggest changing 1 line of code. I'm not signing anything. Its your job to maintain the project so you can either pull or not.

@sotirosn sotirosn closed this Feb 14, 2017
@sotirosn sotirosn reopened this Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants