Fix iOS build with Unity 2019.3 and later #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposed fix only worked for older Unity versions
Thaina
suggested changes
Sep 21, 2020
| // The UnityFramework target will include the code and Unity-iPhone is only a thin wrapper around it. | ||
| // With earlier versions everything is in a single Unity-iPhone target. | ||
| var targetName = GetUnityVersionNumber() >= 201930 ? "UnityFramework" : "Unity-iPhone"; | ||
| string targetGUID = proj.TargetGuidByName(targetName); |
There was a problem hiding this comment.
Will this better?
#if UNITY_2019_3_OR_NEWER
string targetGUID = proj.GetUnityFrameworkTargetGuid();
#else
string targetName = PBXProject.GetUnityTargetName();
string targetGUID = proj.TargetGuidByName(targetName);
#endifThere was a problem hiding this comment.
No, that won't work. We cannot use preprocessor directives here as this file is compiled into a DLL that has to support various Unity versions.
There was a problem hiding this comment.
@Nezz I see but still didn't GetUnityFrameworkTargetGuid and GetUnityTargetName better than constant?
string targetGUID = GetUnityVersionNumber() >= 201930 ? proj.GetUnityFrameworkTargetGuid() : proj.TargetGuidByName(PBXProject.GetUnityTargetName());There was a problem hiding this comment.
GetUnityFrameworkTargetGuid is only available in Unity 2019.3 and later. If you include this DLL in a 2018.4 project, you will get a compiler error.
GetUnityTargetName was removed in Unity 2019.3. If you include this DLL in a 2019.3+ project, you will get a compiler error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bugfor bug fixes)I don't have the permission to add labels.
Pull Request Details
The proposed fix only worked for older Unity versions. Resolves #450.
Test Plan
Build for iOS using various Unity versions