Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Login Callback #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbehshad
Copy link

@rbehshad rbehshad commented Feb 23, 2018

This will fix the login callback not being called on Android if the player backgrounds the app with the login screen visible, and resumes the app from the app launcher (not the recent apps).

Issue: #66

…layer backgrounds the app with the login screen visible, and resumes the app from the app launcher (not the recent apps).
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@adenau
Copy link

adenau commented Aug 3, 2018

Any idea when this could be merged?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@sackdan
Copy link

sackdan commented Mar 6, 2019

Is there anything stopping this from being merged?

@mmizuguchi-glu
Copy link

Is there a plan to merge this fix in?

@rbehshad
Copy link
Author

rbehshad commented Dec 6, 2019

I think it's ready for merge, just waiting on Facebook. @KylinChang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants