chore: fix ESLint warnings, restrict export all syntax #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: fc995fd 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fd2d02339d3d00077f004e 😎 Browse the preview: https://deploy-preview-6605--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6605--docusaurus-2.netlify.app/ |
|
Size Change: -731 B (0%) Total Size: 771 kB
ℹ️ View Unchanged
|
|
not against but not sure what you mean by Aren't we already using ESM before? 🤔 you mean node ESM? |
|
Yes, native Node ESM. Node ESM is able to statically analyze CJS modules and find named exports, but if you use export all, the exported names will not be visible within the index file and therefore you can't do named imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Export all is known to not work in ESM, forcing us to use
import utils from '@docusaurus/utils'; const {aliasedSitePath} = utils;instead ofimport {aliasedSitePath} from '@docusaurus/utils. This makes us more interoperable with ESM contexts (#6520).In addition, I noticed in #6477 that export all seems to be discouraged. The reasoning makes sense.
Have you read the Contributing Guidelines on pull requests?
Yes