-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs, blog): add support for tags.yml
, predefined list of tags
#10137
Open
OzakIOne
wants to merge
131
commits into
main
Choose a base branch
from
ozaki/tagsBlogDoc
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,834
−359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
slorber
requested changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need :
export type VersionMetadata = ContentPaths & {
tagsFile: TagsFile | null;
tagsPath: string;
}
We probably need to modify/rename this method
type TagsFile = Record<string, Tag>
export function normalizeFrontMatterTags(
/** Base path to append the tag permalinks to. */
tagsPath: string,
/** Can be `undefined`, so that we can directly pipe in `frontMatter.tags`. */
frontMatterTags: FrontMatterTag[] | undefined = [],
tagsFile: TagsFile
): Tag[]
packages/docusaurus-plugin-content-docs/src/plugin-content-docs.d.ts
Outdated
Show resolved
Hide resolved
Size Change: +614 B (+0.04%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
User request to have a predefined list of tags in a file which you can only choose from
Behavior :
undefined
: search tags.yml by convention. Feature disabled if file does not existnull/false
(default): feature disabled even if tags.yml existstagFile.yml
: search for tagFile.yml and throw if file does not existWe check for duplicated tags permalink route and throw in case of duplication
Test Plan
yarn jest -t
ensureUniquePermalinks
normalizeTags
normalize tags
normalizeFrontMatterTags
processFileTagsPath
Dogfood
Test links
Guides:
API refs:
Tags pages blog:
Tags pages docs:
Related issues/PRs
fix #5913
#5975