Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): configurePostCss() should run after configureWebpack() #10132

Merged
merged 4 commits into from
May 13, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 10, 2024

Motivation

Fix #10106

It should be possible to have a plugin using configureWebpack() adding some kind of CSS loader, and then have a plugin calling configurePostCss() that configures postCSS for the newly added loader.

Test Plan

New unit tests added

The preview should keep working as before

Test links

https://deploy-preview-10132--docusaurus-2.netlify.app/

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 10, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 10, 2024 17:01
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 10, 2024
@slorber slorber changed the title fix order of executePluginsConfigurePostCss fix(core): fix order of executePluginsConfigurePostCss May 10, 2024
@slorber slorber changed the title fix(core): fix order of executePluginsConfigurePostCss fix(core): configurePostCss() should run after configureWebpack() May 10, 2024
Copy link

netlify bot commented May 10, 2024

[V2]

Name Link
🔨 Latest commit 99705a3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66420786e0c13e0008a96b5e
😎 Deploy Preview https://deploy-preview-10132--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 10, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 55 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 68 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented May 10, 2024

Size Change: 0 B

Total Size: 1.71 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.9 kB
website/.docusaurus/globalData.json 107 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 275 kB
website/.docusaurus/routes.js 179 kB
website/.docusaurus/routesChunkNames.json 119 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 112 kB
website/build/assets/js/main.********.js 853 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label May 12, 2024
Copy link

argos-ci bot commented May 12, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - May 13, 2024, 12:36 PM

@slorber slorber merged commit ff5039f into main May 13, 2024
32 checks passed
@slorber slorber deleted the slorber/fix-configurePostCSS-order branch May 13, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating past 3.1.1 breaks postCSS plugins customisation. Fully debugged, just needs fixing
2 participants